From 5ca472faa6ccc8a70690052528f00d0e3e75bffd Mon Sep 17 00:00:00 2001 From: Baratali Izmailov Date: Mon, 31 Aug 2015 17:04:08 -0400 Subject: [PATCH] Issue #1243: Eclipse warnings about unused fields have been fixed. --- .../checkstyle/test/base/ConfigurationBuilder.java | 3 --- .../tools/checkstyle/api/AutomaticBeanTest.java | 10 +++++++++- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/it/java/com/google/checkstyle/test/base/ConfigurationBuilder.java b/src/it/java/com/google/checkstyle/test/base/ConfigurationBuilder.java index 7e1e75469..3d4494f93 100644 --- a/src/it/java/com/google/checkstyle/test/base/ConfigurationBuilder.java +++ b/src/it/java/com/google/checkstyle/test/base/ConfigurationBuilder.java @@ -5,7 +5,6 @@ import java.io.File; import java.io.FileInputStream; import java.io.IOException; import java.io.InputStreamReader; -import java.net.URL; import java.nio.charset.StandardCharsets; import java.util.ArrayList; import java.util.Collections; @@ -31,8 +30,6 @@ public class ConfigurationBuilder extends BaseCheckTestSupport { private final Pattern warnPattern = CommonUtils.createPattern(".*[ ]*//[ ]*warn[ ]*|/[*]warn[*]/"); - private URL url; - public ConfigurationBuilder(File aROOT) { root = aROOT; configuration = getConfigurationFromXML(XML_NAME, System.getProperties()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java index d8176a91d..ee1d7578c 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java @@ -97,6 +97,14 @@ public class AutomaticBeanTest { } } + @Test(expected = IllegalStateException.class) + public void testTestBean() { + final TestBean testBean = new TestBean(); + testBean.setVal(0); + testBean.setWrong("wrongVal"); + testBean.setExceptionalMethod("someValue"); + } + private static class TestBean extends AutomaticBean { private String privateField; @@ -114,7 +122,7 @@ public class AutomaticBeanTest { } public void setExceptionalMethod(String value) { - throw new IllegalStateException(privateField + value); + throw new IllegalStateException(privateField + "," + wrong + "," + val + "," + value); } }