From 61e6ce5ee716c4a2999b915a00a026277c9e3e46 Mon Sep 17 00:00:00 2001
From: Rick Giles <rickgiles>
Date: Sat, 10 May 2003 10:59:20 +0000
Subject: [PATCH] Added "source" attribute to "error" element of XMLLogger
 output.

---
 docs/releasenotes.html                           |  5 +++++
 .../puppycrawl/tools/checkstyle/XMLLogger.java   |  5 ++++-
 .../tools/checkstyle/XMLLoggerTest.java          | 16 +++++++++++-----
 3 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/docs/releasenotes.html b/docs/releasenotes.html
index 7be5f7b81..5e617d58d 100644
--- a/docs/releasenotes.html
+++ b/docs/releasenotes.html
@@ -122,6 +122,11 @@
           <li class="body">One more option for JavadocMethodCheck 
           (allowThrowsTagsForSubclasses, request 540383)</li>
 
+          <li class="body">Added sourceName property to AuditEvent
+            and LocalizedMessage; and &quot;source&quot; attribute
+            to &quot;error&quot; element of XMLLogger output 
+            (request 686336).</li>
+
         </ul>
 
       <p class="body">
diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/XMLLogger.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/XMLLogger.java
index 700498540..7326993f9 100644
--- a/src/checkstyle/com/puppycrawl/tools/checkstyle/XMLLogger.java
+++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/XMLLogger.java
@@ -117,8 +117,11 @@ public class XMLLogger
             mWriter.print(" severity=\""
                 + aEvt.getSeverityLevel().getName()
                 + "\"");
-            mWriter.println(" message=\""
+            mWriter.print(" message=\""
                 + encode(aEvt.getMessage())
+                + "\"");
+            mWriter.println(" source=\""
+                + encode(aEvt.getSourceName())
                 + "\"/>");
         }
     }
diff --git a/src/tests/com/puppycrawl/tools/checkstyle/XMLLoggerTest.java b/src/tests/com/puppycrawl/tools/checkstyle/XMLLoggerTest.java
index a6cf0ed8e..8f2405496 100644
--- a/src/tests/com/puppycrawl/tools/checkstyle/XMLLoggerTest.java
+++ b/src/tests/com/puppycrawl/tools/checkstyle/XMLLoggerTest.java
@@ -9,6 +9,7 @@ import java.io.PrintWriter;
 import java.util.ArrayList;
 
 import com.puppycrawl.tools.checkstyle.api.LocalizedMessage;
+import com.puppycrawl.tools.checkstyle.api.SeverityLevel;
 
 import junit.framework.TestCase;
 
@@ -121,18 +122,23 @@ public class XMLLoggerTest extends TestCase
         verifyLines(expectedLines);
     }
 
-    public void testAddError()
-        throws IOException
-    {
+    public void testAddError() throws IOException {
         final XMLLogger logger = new XMLLogger(outStream, true);
         logger.auditStarted(null);
         final LocalizedMessage message =
-            new LocalizedMessage( 1, 1, "messages.properties", "key", null);
+            new LocalizedMessage(
+                1,
+                1,
+                "messages.properties",
+                "key",
+                null,
+                SeverityLevel.ERROR,
+                "aSource");
         final AuditEvent ev = new AuditEvent(this, "Test.java", message);
         logger.addError(ev);
         logger.auditFinished(null);
         final String[] expectedLines =
-            {"<error line=\"1\" column=\"1\" severity=\"error\" message=\"key\"/>"};
+            {"<error line=\"1\" column=\"1\" severity=\"error\" message=\"key\" source=\"aSource\"/>"};
         verifyLines(expectedLines);
     }