From 65989e76a40bf085059ee2bf9c695c6b45a771fb Mon Sep 17 00:00:00 2001
From: Oliver Burn <oliver@puppycrawl.com>
Date: Mon, 13 May 2002 01:48:41 +0000
Subject: [PATCH] Request 555262: Include column number in the XML output

---
 build.xml                                     |  1 +
 docs/releasenotes.html                        | 19 +++++++++++++++++++
 .../tools/checkstyle/XMLLogger.java           |  8 +++++---
 3 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/build.xml b/build.xml
index ef8e31c42..991ffc56f 100644
--- a/build.xml
+++ b/build.xml
@@ -187,6 +187,7 @@
                      includes="**/*.java"
                      excludes="**/Generated*.java"/>
             <formatter type="plain"/>
+            <formatter type="xml" toFile="classes/cs_errors.xml"/>
         </checkstyle>
     </target>
 
diff --git a/docs/releasenotes.html b/docs/releasenotes.html
index 3218c277d..7bf4ac4ab 100644
--- a/docs/releasenotes.html
+++ b/docs/releasenotes.html
@@ -26,6 +26,7 @@
     <td valign="top" align="left" nowrap="true" bgcolor="#EEEEEE">
       <p>Checkstyle 2</p>
       <ul>
+        <li><a href="#release2_3">Release 2.3</a></li>
         <li><a href="#release2_2">Release 2.2</a></li>
         <li><a href="#release2_1">Release 2.1</a></li>
         <li><a href="#release2_0">Release 2.0</a></li>
@@ -35,6 +36,24 @@
     <!--Content-->
     <td width="100%" valign="top" align="left">
 
+      <a name="release2_3"></a>
+      <h2>Release 2.3</h2>
+      <p class="body">
+        New features:
+        <ul>
+          <!--(Feature request 555262)-->
+          <li class="body">Include column number in the XML output (request 555262).</li>
+        </ul>
+      </p>
+
+      <p class="body">
+        Resolved bugs:
+        <ul>
+          <li class="body">Bugs! What bugs?</li>
+        </ul>
+      </p>
+
+
       <a name="release2_2"></a>
       <h2>Release 2.2</h2>
       <p class="body">
diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/XMLLogger.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/XMLLogger.java
index 0b604a854..d508038bf 100644
--- a/src/checkstyle/com/puppycrawl/tools/checkstyle/XMLLogger.java
+++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/XMLLogger.java
@@ -109,9 +109,11 @@ public class XMLLogger
     /** @see AuditListener **/
     public void addError(AuditEvent aEvt)
     {
-        mWriter.println("<error " +
-                        "line=\"" + aEvt.getLine() + "\" " +
-                        "message=\"" + encode(aEvt.getMessage()) + "\"/>");
+        mWriter.print("<error" + " line=\"" + aEvt.getLine() + "\"");
+        if (aEvt.getColumn() > 0) {
+            mWriter.print(" column=\"" + aEvt.getColumn() + "\"");
+        }
+        mWriter.println(" message=\"" + encode(aEvt.getMessage()) + "\"/>");
     }
 
     /** @see AuditListener **/