diff --git a/pom.xml b/pom.xml index 882c3aaab..77695851b 100644 --- a/pom.xml +++ b/pom.xml @@ -761,7 +761,6 @@ .*.checks.design.InnerTypeLastCheck10093 .*.checks.design.InterfaceIsTypeCheck10085 - .*.checks.design.MutableExceptionCheck8592 .*.checks.design.OneTopLevelClassCheck7795 .*.checks.design.VisibilityModifierCheck9595 diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java index 4cb1fdffa..e85a69d82 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java @@ -19,15 +19,20 @@ package com.puppycrawl.tools.checkstyle.checks.design; +import antlr.CommonHiddenStreamToken; + import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport; import com.puppycrawl.tools.checkstyle.DefaultConfiguration; +import com.puppycrawl.tools.checkstyle.api.DetailAST; import com.puppycrawl.tools.checkstyle.api.TokenTypes; + import org.junit.Test; import java.io.File; import static com.puppycrawl.tools.checkstyle.checks.design.MutableExceptionCheck.MSG_KEY; import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.fail; public class MutableExceptionCheckTest extends BaseCheckTestSupport { @Test @@ -67,4 +72,18 @@ public class MutableExceptionCheckTest extends BaseCheckTestSupport { int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.VARIABLE_DEF}; assertArrayEquals(expected, obj.getRequiredTokens()); } + + @Test + public void testWrongTokenType() { + MutableExceptionCheck obj = new MutableExceptionCheck(); + DetailAST ast = new DetailAST(); + ast.initialize(new CommonHiddenStreamToken(TokenTypes.INTERFACE_DEF, "interface")); + try { + obj.visitToken(ast); + fail(); + } + catch (IllegalStateException e) { + //expected + } + } } diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/design/InputMutableException.java b/src/test/resources/com/puppycrawl/tools/checkstyle/design/InputMutableException.java index 188d2bfc9..e61ad47df 100644 --- a/src/test/resources/com/puppycrawl/tools/checkstyle/design/InputMutableException.java +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/design/InputMutableException.java @@ -32,6 +32,11 @@ public class InputMutableException { public class CustomFailure extends ThreadDeath { private int errorCode; + public void someMethod() { + if(true) { + final int i = 0; + } + } } } }