From 6839ac4fd83dde7060c8f6f28e75aa3d6ff2456b Mon Sep 17 00:00:00 2001
From: Michal Kordas <kordas.michal@gmail.com>
Date: Fri, 4 Sep 2015 22:15:54 +0200
Subject: [PATCH] Issue #2080: Add missing assertions to utils tests

Fixes some `TestMethodWithoutAssertion` inspection violations.

Description:
>Reports test methods of JUnit test case classes that do not contain any assertions. Such methods indicate either incomplete or weak test cases.
---
 .../checkstyle/utils/CheckUtilsTest.java      |  6 ++++--
 .../checkstyle/utils/CommonUtilsTest.java     | 19 +++++++++++++------
 .../checkstyle/utils/TokenUtilsTest.java      |  1 +
 3 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/utils/CheckUtilsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/utils/CheckUtilsTest.java
index 300ece051..ee0655f75 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/utils/CheckUtilsTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/utils/CheckUtilsTest.java
@@ -20,6 +20,7 @@
 package com.puppycrawl.tools.checkstyle.utils;
 
 import static com.puppycrawl.tools.checkstyle.TestUtils.assertUtilsClassHasPrivateConstructor;
+import static org.junit.Assert.assertEquals;
 
 import org.junit.Assert;
 import org.junit.Test;
@@ -35,8 +36,9 @@ public class CheckUtilsTest {
     }
 
     @Test
-    public void testParseDouble() throws Exception {
-        CheckUtils.parseDouble("1_02", TokenTypes.ASSIGN);
+    public void testParseDoubleWithIncorrectToken() throws Exception {
+        double parsedDouble = CheckUtils.parseDouble("1_02", TokenTypes.ASSIGN);
+        assertEquals(0.0, parsedDouble, 0.0);
     }
 
     @Test
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/utils/CommonUtilsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/utils/CommonUtilsTest.java
index aed6accf5..4b29b3033 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/utils/CommonUtilsTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/utils/CommonUtilsTest.java
@@ -170,14 +170,12 @@ public class CommonUtilsTest {
 
     @Test
     public void testClose() {
+        TestCloseable closeable = new TestCloseable();
+
         CommonUtils.close(null);
+        CommonUtils.close(closeable);
 
-        CommonUtils.close(new Closeable() {
-
-            @Override
-            public void close() {
-            }
-        });
+        assertTrue(closeable.closed);
     }
 
     @Test(expected = IllegalStateException.class)
@@ -190,4 +188,13 @@ public class CommonUtilsTest {
             }
         });
     }
+
+    private static class TestCloseable implements Closeable {
+        private boolean closed;
+
+        @Override
+        public void close() {
+            closed = true;
+        }
+    }
 }
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/utils/TokenUtilsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/utils/TokenUtilsTest.java
index 724d38ce6..8965cbfac 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/utils/TokenUtilsTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/utils/TokenUtilsTest.java
@@ -51,6 +51,7 @@ public class TokenUtilsTest {
 
         try {
             TokenUtils.getIntFromField(field, 0);
+            fail();
         }
         catch (IllegalStateException expected) {
             // expected