From 6e1b8917c105606e8e03cc58cf893aba9a844f0a Mon Sep 17 00:00:00 2001 From: Baratali Izmailov Date: Thu, 9 Jul 2015 12:12:35 -0700 Subject: [PATCH] Issue #1293: One more unit test for PackageDeclarationCheck. --- pom.xml | 1 - .../checks/coding/PackageDeclarationCheckTest.java | 12 +++++++++++- .../checkstyle/coding/InputPackageDeclaration.java | 8 ++++++++ .../{ => coding}/InputWithCommentOnly.java | 0 4 files changed, 19 insertions(+), 2 deletions(-) create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/coding/InputPackageDeclaration.java rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => coding}/InputWithCommentOnly.java (100%) diff --git a/pom.xml b/pom.xml index 3d7c8301f..5f43b1837 100644 --- a/pom.xml +++ b/pom.xml @@ -1113,7 +1113,6 @@ .*.checks.coding.MultipleStringLiteralsCheck9096 .*.checks.coding.MultipleVariableDeclarationsCheck96100 .*.checks.coding.OverloadMethodsDeclarationOrderCheck93100 - .*.checks.coding.PackageDeclarationCheck7585 .*.checks.coding.ParameterAssignmentCheck8096 .*.checks.coding.ReturnCountCheck5574 .*.checks.coding.SimplifyBooleanReturnCheck83100 diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/PackageDeclarationCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/PackageDeclarationCheckTest.java index af67bd193..5d17640db 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/PackageDeclarationCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/PackageDeclarationCheckTest.java @@ -50,7 +50,17 @@ public class PackageDeclarationCheckTest extends BaseCheckTestSupport { "1: " + getCheckMessage(MSG_KEY), }; - verify(checkConfig, getPath("InputWithCommentOnly.java"), expected); + verify(checkConfig, getPath("coding/InputWithCommentOnly.java"), expected); + } + + @Test + public void testCorrectFile() throws Exception { + DefaultConfiguration checkConfig = createCheckConfig(PackageDeclarationCheck.class); + + String[] expected = { + }; + + verify(checkConfig, getPath("coding/InputPackageDeclaration.java"), expected); } @Test diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/coding/InputPackageDeclaration.java b/src/test/resources/com/puppycrawl/tools/checkstyle/coding/InputPackageDeclaration.java new file mode 100644 index 000000000..491acd12c --- /dev/null +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/coding/InputPackageDeclaration.java @@ -0,0 +1,8 @@ +package com.puppycrawl.tools.checkstyle.checks.coding; + +class InputPackageDeclaration { + public String value; + + private void get(){ + } +} \ No newline at end of file diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/InputWithCommentOnly.java b/src/test/resources/com/puppycrawl/tools/checkstyle/coding/InputWithCommentOnly.java similarity index 100% rename from src/test/resources/com/puppycrawl/tools/checkstyle/InputWithCommentOnly.java rename to src/test/resources/com/puppycrawl/tools/checkstyle/coding/InputWithCommentOnly.java