From 787bf0582b7f97db9f1fa884ac048ec5bb84dccc Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Sat, 11 Jul 2015 00:52:27 +0200 Subject: [PATCH] Add test coverage to HtmlTag in Javadoc checks. #1308 --- pom.xml | 1 - .../tools/checkstyle/checks/javadoc/HtmlTag.java | 3 +-- .../tools/checkstyle/InputJavadocStyleCheck.java | 9 +++++++++ 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index bcae5fa4f..a82e4d8af 100644 --- a/pom.xml +++ b/pom.xml @@ -1152,7 +1152,6 @@ .*.checks.javadoc.AbstractJavadocCheck9093 .*.checks.javadoc.AbstractJavadocCheck\$.*5068 .*.checks.javadoc.AtclauseOrderCheck8888 - .*.checks.javadoc.HtmlTag7590 .*.checks.javadoc.JavadocMethodCheck9096 .*.checks.javadoc.JavadocPackageCheck8095 .*.checks.javadoc.JavadocParagraphCheck92100 diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/HtmlTag.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/HtmlTag.java index 9ed947b30..f27ae8e38 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/HtmlTag.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/HtmlTag.java @@ -57,8 +57,7 @@ class HtmlTag { */ HtmlTag(String id, int lineNo, int position, boolean closedTag, boolean incomplete, String text) { - this.id = !"".equals(id) && id.charAt(0) == '/' - ? id.substring(1) : id; + this.id = id; this.lineNo = lineNo; this.position = position; this.text = text; diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/InputJavadocStyleCheck.java b/src/test/resources/com/puppycrawl/tools/checkstyle/InputJavadocStyleCheck.java index 5d4f67aa9..402575968 100644 --- a/src/test/resources/com/puppycrawl/tools/checkstyle/InputJavadocStyleCheck.java +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/InputJavadocStyleCheck.java @@ -338,4 +338,13 @@ public class InputJavadocStyleCheck public void method21() { } + /** + * First sentence. + * < + * /a> + */ + void tagClosedInNextLine() { + + } + }