From 7b0388ee96bf14872ae095da85738af97ef857d5 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Sat, 29 Aug 2015 21:46:27 +0200 Subject: [PATCH] Issue #1555: Replace for loop that misses component with while loop Fixes `ForLoopWithMissingComponent` inspection violation. Description: >Reports for loops that lack initialization, condition, or update clauses. Some coding styles prohibit such loops. --- .../checkstyle/checks/coding/ParameterAssignmentCheck.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ParameterAssignmentCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ParameterAssignmentCheck.java index 80a8a30f6..00b5a8879 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ParameterAssignmentCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ParameterAssignmentCheck.java @@ -235,13 +235,13 @@ public final class ParameterAssignmentCheck extends Check { DetailAST parameterDefAST = ast.findFirstToken(TokenTypes.PARAMETER_DEF); - for (; parameterDefAST != null; - parameterDefAST = parameterDefAST.getNextSibling()) { + while (parameterDefAST != null) { if (parameterDefAST.getType() == TokenTypes.PARAMETER_DEF) { final DetailAST param = parameterDefAST.findFirstToken(TokenTypes.IDENT); parameterNames.add(param.getText()); } + parameterDefAST = parameterDefAST.getNextSibling(); } } }