TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PMD Rule:ExcessiveMethodLength Priority:3 Avoid really long methods . Issue #744

This commit is contained in:
Roman Ivanov 2015-04-21 09:52:03 -07:00
parent bb1646fbcc
commit 7f65ac9c09
1 changed files with 43 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

74
src/main/java/com/puppycrawl/tools/checkstyle/checks/SuppressWarningsHolder.java
View File

@ -277,39 +277,9 @@ public class SuppressWarningsHolder
return;
}
// get target of annotation
DetailAST targetAST = null;
DetailAST parentAST = ast.getParent();
if (parentAST != null) {
switch (parentAST.getType()) {
case TokenTypes.MODIFIERS:
case TokenTypes.ANNOTATIONS:
parentAST = parentAST.getParent();
if (parentAST != null) {
switch (parentAST.getType()) {
case TokenTypes.ANNOTATION_DEF:
case TokenTypes.PACKAGE_DEF:
case TokenTypes.CLASS_DEF:
case TokenTypes.INTERFACE_DEF:
case TokenTypes.ENUM_DEF:
case TokenTypes.ENUM_CONSTANT_DEF:
case TokenTypes.CTOR_DEF:
case TokenTypes.METHOD_DEF:
case TokenTypes.PARAMETER_DEF:
case TokenTypes.VARIABLE_DEF:
targetAST = parentAST;
break;
final DetailAST targetAST = getAnnotationTarget(ast);
default:
// unexpected target type
}
}
break;
default:
// unexpected container type
}
}
if (targetAST == null) {
log(ast, "suppress.warnings.invalid.target");
return;
@ -344,6 +314,48 @@ public class SuppressWarningsHolder
}
}
/**
* get target of annotation
* @param ast the AST node to get the child of
* @return get target of annotation
*/
private DetailAST getAnnotationTarget(DetailAST ast)
{
DetailAST targetAST = null;
DetailAST parentAST = ast.getParent();
if (parentAST != null) {
switch (parentAST.getType()) {
case TokenTypes.MODIFIERS:
case TokenTypes.ANNOTATIONS:
parentAST = parentAST.getParent();
if (parentAST != null) {
switch (parentAST.getType()) {
case TokenTypes.ANNOTATION_DEF:
case TokenTypes.PACKAGE_DEF:
case TokenTypes.CLASS_DEF:
case TokenTypes.INTERFACE_DEF:
case TokenTypes.ENUM_DEF:
case TokenTypes.ENUM_CONSTANT_DEF:
case TokenTypes.CTOR_DEF:
case TokenTypes.METHOD_DEF:
case TokenTypes.PARAMETER_DEF:
case TokenTypes.VARIABLE_DEF:
targetAST = parentAST;
break;
default:
// unexpected target type
}
}
break;
default:
// unexpected container type
}
}
return targetAST;
}
/**
* Returns the n'th child of an AST node.
* @param ast the AST node to get the child of