From 85d6fcba9ce1ac53db7f92ef4ba3d4de5bda3fbc Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Sun, 9 Aug 2015 16:00:35 +0200 Subject: [PATCH] Use isEmpty() instead of "".equals() on strings. #1555 Fixes `StringEqualsEmptyString` inspection violations. Description: >Reports .equals() being called to compare a String with an empty string. It is normally more performant to test a String for emptiness by comparing its .length() to zero instead. --- .../java/com/puppycrawl/tools/checkstyle/api/FileContents.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/api/FileContents.java b/src/main/java/com/puppycrawl/tools/checkstyle/api/FileContents.java index edcb09d34..b05414add 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/api/FileContents.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/api/FileContents.java @@ -269,7 +269,7 @@ public final class FileContents implements CommentListener { **/ public boolean lineIsBlank(int lineNo) { // possible improvement: avoid garbage creation in trim() - return "".equals(line(lineNo).trim()); + return line(lineNo).trim().isEmpty(); } /**