TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue #1555: Rename boolean methods to start with question word 

Fixes `BooleanMethodNameMustStartWithQuestion` inspection violations.

Description:
>Reports boolean methods whose names do not start with a question word. Boolean methods that override library methods are ignored by this inspection.
This commit is contained in:
Michal Kordas 2015-08-28 23:27:51 +02:00 committed by Roman Ivanov
parent 1e541f0b98
commit 8985e645a8
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheck.java
View File

@ -184,7 +184,7 @@ public class GenericWhitespaceCheck extends Check {
//
final int indexOfAmp = line.indexOf('&', after);
if (indexOfAmp >= 0
&& whitespaceBetween(after, indexOfAmp, line)) {
&& containsWhitespaceBetween(after, indexOfAmp, line)) {
if (indexOfAmp - after == 0) {
log(ast.getLineNo(), after, WS_NOT_PRECEDED, "&");
}
@ -294,8 +294,8 @@ public class GenericWhitespaceCheck extends Check {
* @param line the line to check
* @return whether there are only whitespaces (or nothing)
*/
private static boolean whitespaceBetween(
int fromIndex, int toIndex, String line) {
private static boolean containsWhitespaceBetween(
int fromIndex, int toIndex, String line) {
for (int i = fromIndex; i < toIndex; i++) {
if (!Character.isWhitespace(line.charAt(i))) {
return false;

3
src/main/java/com/puppycrawl/tools/checkstyle/doclets/TokenTypesDoclet.java
View File

@ -110,8 +110,7 @@ public final class TokenTypesDoclet {
* @param reporter the reporter to report errors.
* @return true if only valid options was specified
*/
public static boolean validOptions(String[][] options,
DocErrorReporter reporter) {
public static boolean checkOptions(String[][] options, DocErrorReporter reporter) {
boolean foundDestFileOption = false;
for (final String[] opt : options) {
if (DEST_FILE_OPT.equals(opt[0])) {