TouchInstinct
/
checkstyle
311
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix typos in quality profile files. #1555 

Fixes some `SpellCheckingInspection` inspection violations.

Description:
>Spellchecker inspection helps locate typos and misspelling in your code, comments and literals, and fix them in one click.
This commit is contained in:
Michal Kordas 2015-08-24 21:57:50 +02:00 committed by Roman Ivanov
parent 7b14802231
commit 8f86620e72
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
config/findbugs-exclude.xml
View File

@ -5,12 +5,12 @@
<Package name="~com\.puppycrawl\.tools\.checkstyle\.grammars.*" />
</Match>
<Match>
<!-- We are not aware of encoding of files that user has, so using user encodin is ok -->
<!-- We are not aware of encoding of files that user has, so using user encoding is ok -->
<Class name="com.puppycrawl.tools.checkstyle.checks.LineSeparatorOption" />
<Bug pattern="DM_DEFAULT_ENCODING" />
</Match>
<Match>
<!-- Looks like catch Exception and throw BuidException is normal practice in ANT, so we follow their style -->
<!-- Looks like catch Exception and throw BuildException is normal practice in ANT, so we follow their style -->
<!-- Example: https://git-wip-us.apache.org/repos/asf?p=ant.git;a=blob;f=src/main/org/apache/tools/ant/taskdefs/Checksum.java;h=7a94ca098baf241b175a6bab3dda092aed835ada;hb=HEAD#l574 -->
<Class name="com.puppycrawl.tools.checkstyle.ant.CheckstyleAntTask" />
<Method name="createChecker" />
@ -23,7 +23,7 @@
<Bug pattern="REC_CATCH_EXCEPTION" />
</Match>
<Match>
<!-- Deprecated code, code will be removed afer swithing to use JavaDoc AST tree -->
<!-- Deprecated code, code will be removed after switching to use JavaDoc AST tree -->
<Class name="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocUtils" />
<Bug pattern="REC_CATCH_EXCEPTION" />
</Match>
@ -33,13 +33,13 @@
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS" />
</Match>
<Match>
<!-- false-postive, as Map will return null if key is not found -->
<!-- false-positive, as Map will return null if key is not found -->
<Class name="com.puppycrawl.tools.checkstyle.checks.indentation.LineWrappingHandler" />
<Method name="collectFirstNodes" />
<Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" />
</Match>
<Match>
<!-- it is ok here, as business meaning of that cases is not the same, it is ocasional similarity -->
<!-- it is ok here, as business meaning of that cases is not the same, it is occasional similarity -->
<Class name="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck" />
<Method name="visitToken" />
<Bug pattern="DB_DUPLICATE_SWITCH_CLAUSES" />
@ -89,7 +89,7 @@
<Class name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpCheck" />
<!-- createJavadocNode is private and can not be launched without visitToken-->
<Class name="com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocCheck" />
<!-- has only one public method and all nitialized inthat method-->
<!-- has only one public method and all initialized in that method-->
<Class name="com.puppycrawl.tools.checkstyle.checks.regexp.MultilineDetector" />
<!-- beginProcessing() is kind of c-tor -->
<Class name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpMultilineCheck" />

8
config/pmd.xml
View File

@ -21,8 +21,8 @@
<properties>
<property name="showClassesComplexity" value="false"/>
<property name="reportLevel" value="11"/>
<!-- validateCli is not reasonbale to split as incapsulation of logic will be damaged
getDetails - huge Switch, it has to be monolitic
<!-- validateCli is not reasonable to split as encapsulation of logic will be damaged
getDetails - huge Switch, it has to be monolithic
JavadocMethodCheck, JavadocStyleCheck, JavadocUtils.getJavadocTags() - deprecated
FinalLocalVariableCheck.visitToken() - it is just big switch , not could be done
GenericWhitespaceCheck.processSingleGeneric() - it contains a lot of similar to each other and very simple condition
@ -36,7 +36,7 @@
<!-- JavadocMethodCheck - deprecated
WhitespaceAroundCheck.isNotRelevantSituation - npath = 216, but additional extraction
of expression to separate method does not make sense as it will
damage incapsulation of that check.
damage encapsulation of that check.
-->
<property name="violationSuppressXPath" value="//MethodDeclaration[@Name='isNotRelevantSituation' and ../../..[@Image='WhitespaceAroundCheck']] | //MethodDeclaration[@Name='validateCli' and ../../..[@Image='Main']] | //ClassOrInterfaceDeclaration[@Image='JavadocMethodCheck' or @Image='JavadocStyleCheck']"/>
</properties>
@ -144,7 +144,7 @@
<exclude name="PreserveStackTrace"/>
<!-- we will use our own declaration order logic -->
<exclude name="FieldDeclarationsShouldBeAtStartOfClass"/>
<!-- too much alarms of Checks, we will never move logic out of Check, each Check is independed logic contianer -->
<!-- too much alarms of Checks, we will never move logic out of Check, each Check is independent logic container -->
<exclude name="GodClass"/>
</rule>