From 90dc0666ba1f0411ac4f7c8b9b258023661cb4f8 Mon Sep 17 00:00:00 2001 From: Roman Ivanov Date: Sun, 11 Dec 2016 15:08:40 -0800 Subject: [PATCH] Issue #3590: CustomImportControl bad document examples that could lead to false positive on 'special group' --- config/checkstyle_checks.xml | 2 +- src/xdocs/config_imports.xml | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/config/checkstyle_checks.xml b/config/checkstyle_checks.xml index 27721adc0..2d9516b0e 100644 --- a/config/checkstyle_checks.xml +++ b/config/checkstyle_checks.xml @@ -245,7 +245,7 @@ - + diff --git a/src/xdocs/config_imports.xml b/src/xdocs/config_imports.xml index 4b1aca423..ebf89e555 100644 --- a/src/xdocs/config_imports.xml +++ b/src/xdocs/config_imports.xml @@ -391,7 +391,7 @@ import com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck; <module name="CustomImportOrder"> <property name="customImportOrderRules" value="STATIC###STANDARD_JAVA_PACKAGE###SPECIAL_IMPORTS"/> - <property name="specialImportsRegExp" value="org"/> + <property name="specialImportsRegExp" value="^org\."/> <property name="sortImportsInGroupAlphabetically" value="true"/> <property name="separateLineBetweenGroups" value="true"/> </module> @@ -410,8 +410,8 @@ import com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck; <module name="CustomImportOrder"> <property name="customImportOrderRules" value="STATIC###STANDARD_JAVA_PACKAGE###SPECIAL_IMPORTS###THIRD_PARTY_PACKAGE"/> - <property name="specialImportsRegExp" value="org"/> - <property name="thirdPartyPackageRegExp" value="com"/> + <property name="specialImportsRegExp" value="^org\."/> + <property name="thirdPartyPackageRegExp" value="^com\."/> <property name="sortImportsInGroupAlphabetically" value="true"/> <property name="separateLineBetweenGroups" value="true"/> </module> @@ -464,7 +464,7 @@ import com.puppycrawl.tools.checkstyle.checks.imports.AvoidStarImportCheck; <module name="CustomImportOrder"> <property name="customImportOrderRules" value="STATIC###SAME_PACKAGE(3)###THIRD_PARTY_PACKAGE###STANDARD_JAVA_PACKAGE"/> - <property name="thirdPartyPackageRegExp" value="com|org"/> + <property name="thirdPartyPackageRegExp" value="^(com|org)\."/> <property name="standardPackageRegExp" value="^(java|javax)\."/> </module> @@ -522,7 +522,7 @@ import android.*; <module name="CustomImportOrder"> <property name="customImportOrderRules" value="SAME_PACKAGE(3)###THIRD_PARTY_PACKAGE###STATIC###SPECIAL_IMPORTS"/> - <property name="specialImportsRegExp" value="android.*"/> + <property name="specialImportsRegExp" value="^android\."/> </module>