From 9118f376bee8c9281c4458b96fbda8f3ff49bbdc Mon Sep 17 00:00:00 2001 From: Oliver Burn Date: Wed, 4 Dec 2002 06:41:20 +0000 Subject: [PATCH] simplified implementation --- .../checkstyle/checks/IllegalImportCheck.java | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/IllegalImportCheck.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/IllegalImportCheck.java index 8c9deb8c0..fc62cb7d5 100644 --- a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/IllegalImportCheck.java +++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/IllegalImportCheck.java @@ -23,10 +23,6 @@ import com.puppycrawl.tools.checkstyle.api.DetailAST; import com.puppycrawl.tools.checkstyle.api.FullIdent; import com.puppycrawl.tools.checkstyle.api.TokenTypes; -import java.util.Set; -import java.util.TreeSet; -import java.util.Iterator; - /** *

* Checks for imports from a set of illegal packages. @@ -59,8 +55,8 @@ import java.util.Iterator; public class IllegalImportCheck extends AbstractImportCheck { - /** set of illegal packages */ - private final Set mIllegalPkgs = new TreeSet(); + /** list of illegal packages */ + private String[] mIllegalPkgs; /** * Creates a new IllegalImportCheck instance. @@ -76,11 +72,7 @@ public class IllegalImportCheck */ public void setIllegalPkgs(String[] aFrom) { - mIllegalPkgs.clear(); - for (int i = 0; i < aFrom.length; i++) { - final String s = aFrom[i]; - mIllegalPkgs.add(s); - } + mIllegalPkgs = aFrom; } /** @see com.puppycrawl.tools.checkstyle.api.Check */ @@ -108,9 +100,8 @@ public class IllegalImportCheck */ private boolean isIllegalImport(String aImportText) { - for (Iterator it = mIllegalPkgs.iterator(); it.hasNext();) { - final String illegalPkg = (String) it.next(); - if (aImportText.startsWith(illegalPkg + ".")) { + for (int i = 0; i < mIllegalPkgs.length; i++) { + if (aImportText.startsWith(mIllegalPkgs[i] + ".")) { return true; } }