From 95cb60790924d1df7e4e2f091a368c22c02852e3 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Sat, 14 Mar 2015 14:16:57 +0100 Subject: [PATCH] Make inner classes static when possible, issue #778 All violations of Fildbugs rule [SIC: Should be a static inner class](http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC) are fixed. --- .../tools/checkstyle/checks/imports/CustomImportOrderCheck.java | 2 +- .../tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheck.java index 3b805aa41..b6a1a2e37 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheck.java @@ -700,7 +700,7 @@ public class CustomImportOrderCheck extends Check * group. * @author max */ - class ImportDetails + static class ImportDetails { /** Import full path */ private String importFullPath; diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java index 2eae6780b..8a2b2e0af 100755 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java @@ -561,7 +561,7 @@ public abstract class AbstractJavadocCheck extends Check /** * Custom error listener for JavadocParser that prints user readable errors. */ - class DescriptiveErrorListener extends BaseErrorListener + static class DescriptiveErrorListener extends BaseErrorListener { /** * Parse error while token recognition.