TouchInstinct
/
checkstyle
311
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

close cachefile streams, fixes bug #665016

This commit is contained in:
Lars Kühne 2003-01-11 07:39:48 +00:00
parent 1eda2807c8
commit 960d7d03b0
1 changed files with 30 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/checkstyle/com/puppycrawl/tools/checkstyle/PropertyCacheFile.java
View File

@ -65,8 +65,10 @@ class PropertyCacheFile
boolean setInActive = true;
final String fileName = aFileName;
if (fileName != null) {
FileInputStream inStream = null;
try {
mDetails.load(new FileInputStream(fileName));
inStream = new FileInputStream(fileName);
mDetails.load(inStream);
String cachedConfigHash = mDetails.getProperty(CONFIG_HASH_KEY);
String currentConfigHash = getConfigHashCode(aCurrentConfig);
setInActive = false;
@ -87,6 +89,18 @@ class PropertyCacheFile
System.out.println("Unable to open cache file, ignoring.");
e.printStackTrace(System.out);
}
finally {
if (inStream != null) {
try {
inStream.close();
}
catch (IOException ex) {
// TODO: use logger
System.out.println("Unable to close cache file.");
ex.printStackTrace(System.out);
}
}
}
}
mDetailsFile = (setInActive) ? null : fileName;
}
@ -95,13 +109,27 @@ class PropertyCacheFile
void destroy()
{
if (mDetailsFile != null) {
FileOutputStream out = null;
try {
mDetails.store(new FileOutputStream(mDetailsFile), null);
out = new FileOutputStream(mDetailsFile);
mDetails.store(out, null);
}
catch (IOException e) {
System.out.println("Unable to save cache file");
e.printStackTrace(System.out);
}
finally {
if (out != null) {
try {
out.flush();
out.close();
}
catch (IOException ex) {
System.out.println("Unable to close cache file");
ex.printStackTrace(System.out);
}
}
}
}
}