TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove dead code from FinalClassCheck, #1100

This commit is contained in:
vlad 2015-05-19 02:26:05 +03:00 committed by Roman Ivanov
parent 2c99b9706e
commit 989745bb60
1 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/main/java/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheck.java
View File

@ -66,16 +66,13 @@ public class FinalClassCheck
final DetailAST modifiers = ast.findFirstToken(TokenTypes.MODIFIERS);
if (ast.getType() == TokenTypes.CLASS_DEF) {
final boolean isFinal = modifiers != null
&& modifiers.branchContains(TokenTypes.FINAL);
final boolean isAbstract = modifiers != null
&& modifiers.branchContains(TokenTypes.ABSTRACT);
final boolean isFinal = modifiers.branchContains(TokenTypes.FINAL);
final boolean isAbstract = modifiers.branchContains(TokenTypes.ABSTRACT);
classes.push(new ClassDesc(isFinal, isAbstract));
}
else if (!ScopeUtils.inEnumBlock(ast)) { //ctors in enums don't matter
final ClassDesc desc = classes.peek();
if (modifiers != null
&& modifiers.branchContains(TokenTypes.LITERAL_PRIVATE)) {
if (modifiers.branchContains(TokenTypes.LITERAL_PRIVATE)) {
desc.reportPrivateCtor();
}
else {
@ -168,16 +165,5 @@ public class FinalClassCheck
boolean isDeclaredAsAbstract() {
return declaredAsAbstract;
}
@Override
public String toString() {
return this.getClass().getName()
+ "["
+ "final=" + declaredAsFinal
+ " abstract=" + declaredAsAbstract
+ " pctor=" + withPrivateCtor
+ " ctor=" + withNonPrivateCtor
+ "]";
}
}
}