From 9b5594952d79cbf6a0d79d4b81e50b156d2d48e9 Mon Sep 17 00:00:00 2001 From: Roman Ivanov Date: Wed, 22 Apr 2015 12:38:46 -0700 Subject: [PATCH] Rule:UnnecessaryConstructor Priority:3 Avoid unnecessary constructors - the compiler will generate these for you. Issue #744 --- .../checkstyle/checks/coding/DefaultComesLastCheck.java | 6 ------ .../tools/checkstyle/checks/coding/FallThroughCheck.java | 6 ------ .../checks/coding/MultipleVariableDeclarationsCheck.java | 5 ----- .../tools/checkstyle/checks/coding/RequireThisCheck.java | 5 ----- .../tools/checkstyle/checks/imports/UnusedImportsCheck.java | 5 ----- .../checkstyle/checks/indentation/IndentationCheck.java | 5 ----- 6 files changed, 32 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/DefaultComesLastCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/DefaultComesLastCheck.java index 6b50e378b..e03184a8f 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/DefaultComesLastCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/DefaultComesLastCheck.java @@ -49,12 +49,6 @@ public class DefaultComesLastCheck extends Check */ public static final String MSG_KEY = "default.comes.last"; - /** Creates new instance of the check. */ - public DefaultComesLastCheck() - { - // do nothing - } - @Override public int[] getDefaultTokens() { diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FallThroughCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FallThroughCheck.java index d6e750813..408ae45eb 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FallThroughCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FallThroughCheck.java @@ -86,12 +86,6 @@ public class FallThroughCheck extends Check /** Relief regexp. */ private Pattern regExp; - /** Creates new instance of the check. */ - public FallThroughCheck() - { - // do nothing - } - @Override public int[] getDefaultTokens() { diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleVariableDeclarationsCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleVariableDeclarationsCheck.java index c265278a2..e1be07d63 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleVariableDeclarationsCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleVariableDeclarationsCheck.java @@ -57,11 +57,6 @@ public class MultipleVariableDeclarationsCheck extends Check */ public static final String MSG_MULTIPLE_COMMA = "multiple.variable.declarations.comma"; - /** Creates new instance of the check. */ - public MultipleVariableDeclarationsCheck() - { - } - @Override public int[] getDefaultTokens() { diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheck.java index 8352bbf3f..5f1e23eb9 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheck.java @@ -105,11 +105,6 @@ public class RequireThisCheck extends DeclarationCollector return checkMethods; } - /** Creates new instance of the check. */ - public RequireThisCheck() - { - } - @Override public int[] getDefaultTokens() { diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/UnusedImportsCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/UnusedImportsCheck.java index 3a5141a87..ca5a13e5a 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/UnusedImportsCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/UnusedImportsCheck.java @@ -80,11 +80,6 @@ public class UnusedImportsCheck extends Check /** set of references - possibly to imports or other things. */ private final Set referenced = Sets.newHashSet(); - /** Default constructor. */ - public UnusedImportsCheck() - { - } - public void setProcessJavadoc(boolean value) { processJavadoc = value; diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheck.java index 753db1481..a18aae5b3 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheck.java @@ -141,11 +141,6 @@ public class IndentationCheck extends Check /** factory from which handlers are distributed */ private final HandlerFactory handlerFactory = new HandlerFactory(); - /** Creates a new instance of IndentationCheck. */ - public IndentationCheck() - { - } - /** * Get forcing strict condition. * @return forceStrictCondition value.