TouchInstinct
/
checkstyle
306
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

efficiency improvement - don't go up the tree twice.

This commit is contained in:
Rick Giles 2003-05-30 20:41:00 +00:00
parent 1878e21451
commit a2ed8a53c5
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/checkstyle/com/puppycrawl/tools/checkstyle/checks/MagicNumberCheck.java
View File

@ -142,9 +142,6 @@ public class MagicNumberCheck extends Check
*/
private boolean isConstantDefinition(DetailAST aAST)
{
if (ScopeUtils.inInterfaceBlock(aAST)) {
return true;
}
DetailAST parent = aAST.getParent();
//expression?
@ -169,10 +166,11 @@ public class MagicNumberCheck extends Check
return false;
}
//final?
//final or interface constant
final DetailAST modifiersAST =
parent.findFirstToken(TokenTypes.MODIFIERS);
return modifiersAST.branchContains(TokenTypes.FINAL);
return modifiersAST.branchContains(TokenTypes.FINAL)
|| ScopeUtils.inInterfaceBlock(parent);
}
/**