From a3fdd52b45375939c18963e4363f44fe87bbe3cd Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Mon, 17 Aug 2015 22:40:05 +0200 Subject: [PATCH] Promote anonymous class to nested class. #1555 Fixes `AnonymousClassMethodCount` inspection violation in test code. Description: >Reports anonymous inner class with too many methods. Anonymous classes with more than a very low number of methods may be difficult to understand, and should probably be promoted to become named inner classes. --- .../api/AbstractViolationReporterTest.java | 34 ++++++++++--------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/AbstractViolationReporterTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/AbstractViolationReporterTest.java index 05522d8ed..5b621f521 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/AbstractViolationReporterTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/AbstractViolationReporterTest.java @@ -35,22 +35,7 @@ import com.puppycrawl.tools.checkstyle.DefaultConfiguration; * @author lkuehne */ public class AbstractViolationReporterTest extends BaseCheckTestSupport { - private final Check emptyCheck = new Check() { - @Override - public int[] getDefaultTokens() { - return ArrayUtils.EMPTY_INT_ARRAY; - } - - @Override - public int[] getAcceptableTokens() { - return ArrayUtils.EMPTY_INT_ARRAY; - } - - @Override - public int[] getRequiredTokens() { - return ArrayUtils.EMPTY_INT_ARRAY; - } - }; + private final Check emptyCheck = new EmptyCheck(); @Test public void testGetMessageBundleWithPackage() { @@ -123,4 +108,21 @@ public class AbstractViolationReporterTest extends BaseCheckTestSupport { //format messages.first().getMessage(); } + + private static class EmptyCheck extends Check { + @Override + public int[] getDefaultTokens() { + return ArrayUtils.EMPTY_INT_ARRAY; + } + + @Override + public int[] getAcceptableTokens() { + return ArrayUtils.EMPTY_INT_ARRAY; + } + + @Override + public int[] getRequiredTokens() { + return ArrayUtils.EMPTY_INT_ARRAY; + } + } }