TouchInstinct
/
checkstyle
306
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Specify charset used in test code. #1555 

Fixes `ImplicitDefaultCharsetUsage` inspection violations.

Description:
>Reports method and constructor calls which implicitly use the platform's default charset. These can produce different results on (e.g. foreign language) systems that use a different default charset, resulting in unexpected behaviour.
This commit is contained in:
Michal Kordas 2015-08-22 23:54:53 +02:00 committed by Roman Ivanov
parent 4088948e24
commit a992ca414f
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/it/java/com/google/checkstyle/test/base/BaseCheckTestSupport.java
View File

@ -12,6 +12,7 @@ import java.io.LineNumberReader;
import java.io.OutputStream;
import java.io.PrintStream;
import java.io.UnsupportedEncodingException;
import java.nio.charset.StandardCharsets;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
@ -130,7 +131,7 @@ public abstract class BaseCheckTestSupport
final ByteArrayInputStream bais =
new ByteArrayInputStream(baos.toByteArray());
final LineNumberReader lnr =
new LineNumberReader(new InputStreamReader(bais));
new LineNumberReader(new InputStreamReader(bais, StandardCharsets.UTF_8));
for (int i = 0; i < aExpected.length; i++) {
final String expected = aMessageFileName + ":" + aExpected[i];

3
src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/WriteTagCheckTest.java
View File

@ -29,6 +29,7 @@ import java.io.ByteArrayInputStream;
import java.io.File;
import java.io.InputStreamReader;
import java.io.LineNumberReader;
import java.nio.charset.StandardCharsets;
import java.util.Collections;
import java.util.List;
@ -204,7 +205,7 @@ public class WriteTagCheckTest extends BaseCheckTestSupport {
final ByteArrayInputStream bais =
new ByteArrayInputStream(baos.toByteArray());
final LineNumberReader lnr =
new LineNumberReader(new InputStreamReader(bais));
new LineNumberReader(new InputStreamReader(bais, StandardCharsets.UTF_8));
for (int i = 0; i < expected.length; i++) {
final String expectedResult = messageFileName + ":" + expected[i];