From b0902e01cc10bca3eb99151aad0cf1c52ed2ccc7 Mon Sep 17 00:00:00 2001 From: Oliver Burn Date: Sun, 30 Mar 2003 02:38:42 +0000 Subject: [PATCH] Minor syntax. I really like this check as I used to use the idiom. BTW, I think an input test file has not been added to CVS as the unit test fails. --- .../checkstyle/checks/DoubleCheckedLockingCheck.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/DoubleCheckedLockingCheck.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/DoubleCheckedLockingCheck.java index 2050477fd..a4d97458f 100644 --- a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/DoubleCheckedLockingCheck.java +++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/DoubleCheckedLockingCheck.java @@ -30,8 +30,8 @@ import com.puppycrawl.tools.checkstyle.api.TokenTypes; * * See The "Double-Checked Locking is Broken" Declaration - * for a more in depth explanation. + * >The "Double-Checked Locking is Broken" Declaration for a + * more in depth explanation. * * @author Lars Kühne */ @@ -46,13 +46,13 @@ public class DoubleCheckedLockingCheck extends Check /** @see Check */ public void visitToken(DetailAST aAST) { - DetailAST synchronizedAST = + final DetailAST synchronizedAST = getLowestParent(aAST, TokenTypes.LITERAL_SYNCHRONIZED); if (synchronizedAST == null) { return; } - DetailAST ifAST = + final DetailAST ifAST = getLowestParent(synchronizedAST, TokenTypes.LITERAL_IF); if (ifAST == null) { return; @@ -83,8 +83,8 @@ public class DoubleCheckedLockingCheck extends Check private DetailAST getLowestParent(DetailAST aAST, int aTokenType) { DetailAST synchronizedParent = aAST; - while (synchronizedParent != null - && synchronizedParent.getType() != aTokenType) + while ((synchronizedParent != null) + && (synchronizedParent.getType() != aTokenType)) { synchronizedParent = synchronizedParent.getParent(); }