diff --git a/docs/releasenotes.html b/docs/releasenotes.html index bffc187e1..486f3075b 100644 --- a/docs/releasenotes.html +++ b/docs/releasenotes.html @@ -201,6 +201,9 @@ checkstyle-user).
diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheck.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheck.java index 1aa7c2f8b..b87fdb4e8 100755 --- a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheck.java +++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheck.java @@ -238,10 +238,7 @@ public class RequireThisCheck extends Check final String name = aAST.getText(); final LexicalFrame declared = this.mFrames.findFrame(name); - if (declared == null) { - log(aAST, "require.this.unfound.variable", name); - } - else if (declared instanceof ClassFrame) { + if (declared instanceof ClassFrame) { log(aAST, "require.this.variable", name); } } diff --git a/src/testinputs/com/puppycrawl/tools/checkstyle/coding/InputRequireThis.java b/src/testinputs/com/puppycrawl/tools/checkstyle/coding/InputRequireThis.java index 10cc9cbd3..526dcbcf2 100755 --- a/src/testinputs/com/puppycrawl/tools/checkstyle/coding/InputRequireThis.java +++ b/src/testinputs/com/puppycrawl/tools/checkstyle/coding/InputRequireThis.java @@ -10,7 +10,7 @@ public class InputRequireThis { i++; this.i = i; method1(); - j--; + j--; // unhandled for now try { this.method1(); } @@ -18,5 +18,7 @@ public class InputRequireThis { e.printStackTrace(); } this.i--; + + Integer.toString(10); } } diff --git a/src/tests/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java b/src/tests/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java index aab706379..5f649417c 100755 --- a/src/tests/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java +++ b/src/tests/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java @@ -14,7 +14,7 @@ public class RequireThisCheckTest extends BaseCheckTestCase final String[] expected = { "6:9: Reference to instance variable 'i' needs \"this.\".", "12:9: Method call to 'method1' needs \"this.\".", - "13:9: Unable find where 'j' is declared.", +// "13:9: Unable find where 'j' is declared.", }; verify(checkConfig, getPath("coding" + File.separator + "InputRequireThis.java"), @@ -41,7 +41,7 @@ public class RequireThisCheckTest extends BaseCheckTestCase checkConfig.addAttribute("checkMethods", "false"); final String[] expected = { "6:9: Reference to instance variable 'i' needs \"this.\".", - "13:9: Unable find where 'j' is declared.", +// "13:9: Unable find where 'j' is declared.", }; verify(checkConfig, getPath("coding" + File.separator + "InputRequireThis.java"),