From b77a69477c9098d7cdd07567fed03f07dadaba79 Mon Sep 17 00:00:00 2001 From: Roman Ivanov Date: Thu, 23 Jun 2016 21:05:41 -0700 Subject: [PATCH] minor: update for PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5ac364692..234cfa285 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,14 +1,24 @@ Mandatory: + 0) Issue you are tryining to fix/resolve has to have "approved" label. + 1) Put in description of Pull Request reference to issue if it exists. Example: "Issue: #XXXXXX" + 2) Proper commit message should adhere to the following rules: - a) Must match one of the following patterns:\n" + + a) Must match one of the following patterns: + ^Issue #\\d+: .*$ + ^Pull #\\d+: .*$ + ^(minor|config|infra|doc|spelling): .*$ + b) It contains only one line of text + c) Must not end with a period, space, or tab + To avoid multiple iterations of fixes and CIs failures, please read http://checkstyle.sourceforge.net/contributing.html -ATTENTION: We are not merging Pull Requests that not passing your CIs. \ No newline at end of file +ATTENTION: We are not merging Pull Requests that not passing your CIs.