diff --git a/pom.xml b/pom.xml index 2dab0057e..f2c7c480f 100644 --- a/pom.xml +++ b/pom.xml @@ -1151,7 +1151,6 @@ .*.checks.javadoc.AbstractJavadocCheck\$.*5068 .*.checks.javadoc.AtclauseOrderCheck8888 .*.checks.javadoc.JavadocMethodCheck9198 - .*.checks.javadoc.JavadocPackageCheck8095 .*.checks.javadoc.JavadocParagraphCheck92100 .*.checks.javadoc.JavadocStyleCheck8998 .*.checks.javadoc.JavadocTypeCheck9593 diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocPackageCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocPackageCheckTest.java index 56cd9e43f..222a3ca83 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocPackageCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocPackageCheckTest.java @@ -24,6 +24,8 @@ import com.puppycrawl.tools.checkstyle.DefaultConfiguration; import com.puppycrawl.tools.checkstyle.api.Configuration; import org.junit.Test; +import java.io.File; + import static com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck.MSG_LEGACY_PACKAGE_HTML; import static com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck.MSG_PACKAGE_INFO; @@ -50,6 +52,35 @@ public class JavadocPackageCheckTest expected); } + @Test + public void testMissingWithAllowLegacy() throws Exception { + final DefaultConfiguration checkConfig = createCheckConfig(JavadocPackageCheck.class); + checkConfig.addAttribute("allowLegacy", "true"); + final String[] expected = { + "0: " + getCheckMessage(MSG_PACKAGE_INFO), + }; + verify( + createChecker(checkConfig), + getSrcPath("checks/javadoc/BadCls.java"), + getSrcPath("checks/javadoc/BadCls.java"), + expected); + } + + @Test + public void testWithMultipleFiles() throws Exception { + final Configuration checkConfig = createCheckConfig(JavadocPackageCheck.class); + final String path1 = getPath("javadoc/InputNoJavadoc.java"); + final String path2 = getPath("javadoc/InputBadTag.java"); + final String[] expected = { + "0: " + getCheckMessage(MSG_PACKAGE_INFO), + }; + verify( + createChecker(checkConfig), + new File[] {new File(path1), new File(path2)}, + path1, + expected); + } + @Test public void testBoth() throws Exception { final Configuration checkConfig = createCheckConfig(JavadocPackageCheck.class);