From bb1646fbcc6a1f882adcb8b4e299447a5a9f6f98 Mon Sep 17 00:00:00 2001
From: Michal Kordas <kontakt@michalkordas.com>
Date: Mon, 20 Apr 2015 23:11:09 +0200
Subject: [PATCH] Provide exclusions for PMD 'optimizations' ruleset, issue
 #942

---
 config/pmd.xml | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/config/pmd.xml b/config/pmd.xml
index 41b7e90ae..8db83deb1 100644
--- a/config/pmd.xml
+++ b/config/pmd.xml
@@ -24,7 +24,20 @@
   <!--<rule ref="rulesets/java/logging-java.xml"/>-->
   <rule ref="rulesets/java/migrating.xml"/>
   <!--<rule ref="rulesets/java/naming.xml"/>-->
-  <!--<rule ref="rulesets/java/optimizations.xml"/>-->
+  <rule ref="rulesets/java/optimizations.xml">
+    <!--produces more false-positives than real problems-->
+    <exclude name="AvoidInstantiatingObjectsInLoops"/>
+    <!--pollutes code with modifiers-->
+    <exclude name="LocalVariableCouldBeFinal"/>
+    <!--pollutes code with modifiers-->
+    <exclude name="MethodArgumentCouldBeFinal"/>
+    <!--till #948-->
+    <exclude name="PrematureDeclaration"/>
+    <!--till #949-->
+    <exclude name="SimplifyStartsWith"/>
+    <!--not configurable, decreases readability-->
+    <exclude name="UseStringBufferForStringAppends"/>
+  </rule>
   <!--<rule ref="rulesets/java/strictexception.xml"/>-->
   <rule ref="rulesets/java/strings.xml"/>
   <rule ref="rulesets/java/sunsecure.xml"/>