TouchInstinct
/
checkstyle
306
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Encapsulate package-visible fields. #1555 

Fixes `PackageVisibleField` inspection violations.

Description:
>Reports package-visible instance variables. Constants (i.e. variables marked static and final) are not reported.
This commit is contained in:
Michal Kordas 2015-08-23 22:41:25 +02:00 committed by Roman Ivanov
parent 2071f9b542
commit bee8aab67c
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/it/java/com/google/checkstyle/test/base/ConfigValidationTest.java
View File

@ -15,7 +15,7 @@ public class ConfigValidationTest extends BaseCheckTestSupport {
@Test
public void testGoogleChecks() throws Exception {
ConfigurationBuilder builder = new ConfigurationBuilder(new File("src/it/"));
final Configuration checkerConfig = builder.config;
final Configuration checkerConfig = builder.getConfiguration();
final Checker checker = new Checker();
checker.setModuleClassLoader(Thread.currentThread().getContextClassLoader());
checker.configure(checkerConfig);

14
src/it/java/com/google/checkstyle/test/base/ConfigurationBuilder.java
View File

@ -25,16 +25,16 @@ public class ConfigurationBuilder extends BaseCheckTestSupport {
private final List<File> files = new ArrayList<>();
final Configuration config;
private final Configuration configuration;
URL url;
private final Pattern warnPattern = Utils.createPattern(".*[ ]*//[ ]*warn[ ]*|/[*]warn[*]/");
final Pattern warnPattern = Utils.createPattern(".*[ ]*//[ ]*warn[ ]*|/[*]warn[*]/");
private URL url;
public ConfigurationBuilder(File aROOT)
throws CheckstyleException {
root = aROOT;
config = getConfigurationFromXML(XML_NAME, System.getProperties());
configuration = getConfigurationFromXML(XML_NAME, System.getProperties());
listFiles(files, root, "java");
}
@ -51,8 +51,12 @@ public class ConfigurationBuilder extends BaseCheckTestSupport {
}
}
Configuration getConfiguration() {
return configuration;
}
public Configuration getCheckConfig(String aCheckName) {
for (Configuration currentConfig : config.getChildren()) {
for (Configuration currentConfig : getConfiguration().getChildren()) {
if ("TreeWalker".equals(currentConfig.getName())) {
for (Configuration checkConfig : currentConfig.getChildren()) {
if (aCheckName.equals(checkConfig.getName())) {