From bf94ea4127b17c5ab6987ee2e294d2d4b6a1c20f Mon Sep 17 00:00:00 2001 From: rnveach Date: Wed, 14 Oct 2015 15:19:11 -0400 Subject: [PATCH] Issue #2161: unify test input locations for javadoc package --- config/intellij-idea-inspection-scope.xml | 2 +- .../javadoc/AbstractJavadocCheckTest.java | 16 +++-- .../javadoc/AbstractTypeAwareCheckTest.java | 12 +++- .../javadoc/AtclauseOrderCheckTest.java | 14 ++++- .../javadoc/JavadocMethodCheckTest.java | 14 +++-- .../javadoc/JavadocPackageCheckTest.java | 37 ++++++----- .../javadoc/JavadocParagraphCheckTest.java | 16 +++-- .../checks/javadoc/JavadocStyleCheckTest.java | 31 ++++----- ...ocTagContinuationIndentationCheckTest.java | 14 ++++- .../checks/javadoc/JavadocTypeCheckTest.java | 15 +++-- .../javadoc/JavadocVariableCheckTest.java | 15 +++-- .../NonEmptyAtclauseDescriptionCheckTest.java | 10 ++- .../javadoc/SingleLineJavadocCheckTest.java | 12 +++- .../javadoc/SummaryJavadocCheckTest.java | 19 ++++-- .../checks/javadoc/WriteTagCheckTest.java | 7 +++ .../javadoc/JavadocParseTreeTest.java | 63 +++++++++++-------- .../javadoc/ParseTreeBuilder.java | 2 +- .../{ => checks}/javadoc/InputBadTag.java | 2 +- .../InputCorrectAtClauseOrderCheck.java | 2 +- .../InputCorrectJavaDocParagraphCheck.java | 2 +- .../InputCorrectSummaryJavaDocCheck.java | 2 +- .../{ => checks}/javadoc/InputCustomTag.java | 2 +- .../javadoc/InputGuavaFalsePositive.java | 2 +- .../InputIncorrectAtClauseOrderCheck.java | 2 +- .../InputIncorrectJavaDocParagraphCheck.java | 2 +- .../InputIncorrectSummaryJavaDocCheck.java | 2 +- ...nputJavaDocTagContinuationIndentation.java | 4 +- ...aDocTagContinuationIndentationOffset3.java | 2 +- .../javadoc}/InputJavadocStyleCheck.java | 2 +- .../InputJavadocStyleCheckHtmlComment.java | 2 +- .../{ => checks}/javadoc/InputLoadErrors.java | 2 +- .../{ => checks}/javadoc/InputNoJavadoc.java | 2 +- ...InputNonEmptyAtclauseDescriptionCheck.java | 2 +- .../javadoc/InputParsingErrors.java | 2 +- .../javadoc/InputSingleLineJavadocCheck.java | 2 +- .../InputSummaryJavadocCheckNoPeriod.java | 2 +- .../InputSummaryJavadocCheckPeriod.java | 2 +- .../InputTestNumberFormatException.java | 4 ++ .../{ => checks/javadoc}/InputWriteTag.java | 2 +- .../{ => checks/javadoc}/InputWriteTag2.java | 2 +- .../checks/javadoc/bothfiles/Ignored.java | 5 ++ .../javadoc/bothfiles/package-info.java | 1 + .../javadoc/bothfiles/package.html | 0 .../checks/javadoc/pkghtml/Ignored.java | 5 ++ .../{ => checks}/javadoc/pkghtml/package.html | 0 .../pkginfo/annotation/package-info.java | 2 +- .../pkginfo/invalidformat/package-info.java | 4 ++ .../pkginfo/invalidinherit/package-info.java | 4 ++ .../javadoc/pkginfo/valid/package-info.java | 2 +- .../InputTestNumberFormatException.java | 4 -- .../checkstyle/javadoc/bothfiles/Ignored.java | 5 -- .../javadoc/bothfiles/package-info.java | 1 - .../checkstyle/javadoc/pkghtml/Ignored.java | 5 -- .../pkginfo/invalidformat/package-info.java | 4 -- .../pkginfo/invalidinherit/package-info.java | 4 -- 55 files changed, 245 insertions(+), 150 deletions(-) rename src/test/java/com/puppycrawl/tools/checkstyle/{checks => grammars}/javadoc/JavadocParseTreeTest.java (80%) rename src/test/java/com/puppycrawl/tools/checkstyle/{checks => grammars}/javadoc/ParseTreeBuilder.java (99%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputBadTag.java (60%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputCorrectAtClauseOrderCheck.java (99%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputCorrectJavaDocParagraphCheck.java (97%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputCorrectSummaryJavaDocCheck.java (98%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputCustomTag.java (62%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputGuavaFalsePositive.java (84%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputIncorrectAtClauseOrderCheck.java (99%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputIncorrectJavaDocParagraphCheck.java (97%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputIncorrectSummaryJavaDocCheck.java (97%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputJavaDocTagContinuationIndentation.java (98%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputJavaDocTagContinuationIndentationOffset3.java (91%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks/javadoc}/InputJavadocStyleCheck.java (99%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks/javadoc}/InputJavadocStyleCheckHtmlComment.java (97%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputLoadErrors.java (73%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputNoJavadoc.java (97%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputNonEmptyAtclauseDescriptionCheck.java (96%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputParsingErrors.java (71%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputSingleLineJavadocCheck.java (94%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputSummaryJavadocCheckNoPeriod.java (84%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/InputSummaryJavadocCheckPeriod.java (87%) create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/InputTestNumberFormatException.java rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks/javadoc}/InputWriteTag.java (91%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks/javadoc}/InputWriteTag2.java (90%) create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/bothfiles/Ignored.java create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/bothfiles/package-info.java rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/bothfiles/package.html (100%) create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/pkghtml/Ignored.java rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/pkghtml/package.html (100%) rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/pkginfo/annotation/package-info.java (73%) create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/pkginfo/invalidformat/package-info.java create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/pkginfo/invalidinherit/package-info.java rename src/test/resources/com/puppycrawl/tools/checkstyle/{ => checks}/javadoc/pkginfo/valid/package-info.java (73%) delete mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/javadoc/InputTestNumberFormatException.java delete mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/javadoc/bothfiles/Ignored.java delete mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/javadoc/bothfiles/package-info.java delete mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/javadoc/pkghtml/Ignored.java delete mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/javadoc/pkginfo/invalidformat/package-info.java delete mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/javadoc/pkginfo/invalidinherit/package-info.java diff --git a/config/intellij-idea-inspection-scope.xml b/config/intellij-idea-inspection-scope.xml index 529a79c5f..9fdfad167 100644 --- a/config/intellij-idea-inspection-scope.xml +++ b/config/intellij-idea-inspection-scope.xml @@ -1,4 +1,4 @@ - + diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java index 85d231f8b..e2e11ce01 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java @@ -24,6 +24,9 @@ import static com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocChec import static com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocCheck.PARSE_ERROR_MESSAGE_KEY; import static com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocCheck.UNRECOGNIZED_ANTLR_ERROR_MESSAGE_KEY; +import java.io.File; +import java.io.IOException; + import org.apache.commons.lang3.ArrayUtils; import org.junit.Test; @@ -35,6 +38,11 @@ import com.puppycrawl.tools.checkstyle.api.DetailNode; import com.puppycrawl.tools.checkstyle.api.TokenTypes; public class AbstractJavadocCheckTest extends BaseCheckTestSupport { + @Override + protected String getPath(String filename) throws IOException { + return super.getPath("checks" + File.separator + + "javadoc" + File.separator + filename); + } @Test public void testNumberFormatException() throws Exception { @@ -44,7 +52,7 @@ public class AbstractJavadocCheckTest extends BaseCheckTestSupport { + "alternative at input '