TouchInstinct
/
checkstyle
308
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove string concatenation in format string argument. #1555 

Fixes `StringConcatenationInFormatCall` inspection violations.

Description:
>Reports non-constant string concatenations used as a format string argument. Often this is the result of mistakenly concatenating a string format argument by typing a '+' when a ',' was meant. This inspection checks calls to appropriate methods on java.util.Formatter, java.lang.String, java.io.PrintWriter, or java.io.PrintStream.
This commit is contained in:
Michal Kordas 2015-08-16 01:58:11 +02:00 committed by Roman Ivanov
parent 931af7ec14
commit c0a69490d7
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/test/java/com/puppycrawl/tools/checkstyle/MainTest.java
View File

@ -180,12 +180,10 @@ public class MainTest {
ResourceBundle.getBundle("checkstylecompilation");
String version = compilationProperties.getString("checkstyle.compile.version");
assertEquals(String.format("<?xml version=\"1.0\" encoding=\"UTF-8\"?>%n"
+ "<checkstyle version=\"" + version + "\">%n"
+ "<file name=\""
+ expectedPath
+ "\">%n"
+ "<checkstyle version=\"%s\">%n"
+ "<file name=\"%s\">%n"
+ "</file>%n"
+ "</checkstyle>%n"), systemOut.getLog());
+ "</checkstyle>%n", version, expectedPath), systemOut.getLog());
assertEquals("", systemErr.getLog());
}
});
@ -219,11 +217,11 @@ public class MainTest {
+ "/src/test/resources/com/puppycrawl/tools/checkstyle/InputMain.java"
.replace("/", File.separator);
assertEquals(String.format("Starting audit...%n"
+ expectedPath + ":3:14: "
+ "%1$s:3:14: "
+ "warning: Name 'InputMain' must match pattern '^[a-z0-9]*$'.%n"
+ expectedPath + ":5:7: "
+ "%1$s:5:7: "
+ "warning: Name 'InputMainInner' must match pattern '^[a-z0-9]*$'.%n"
+ "Audit done.%n"),
+ "Audit done.%n", expectedPath),
systemOut.getLog());
assertEquals("", systemErr.getLog());
}
@ -243,12 +241,12 @@ public class MainTest {
+ "/src/test/resources/com/puppycrawl/tools/checkstyle/InputMain.java"
.replace("/", File.separator);
assertEquals(String.format("Starting audit...%n"
+ expectedPath + ":3:14: "
+ "%1$s:3:14: "
+ "Name 'InputMain' must match pattern '^[a-z0-9]*$'.%n"
+ expectedPath + ":5:7: "
+ "%1$s:5:7: "
+ "Name 'InputMainInner' must match pattern '^[a-z0-9]*$'.%n"
+ "Audit done.%n"
+ "Checkstyle ends with 2 errors.%n"), systemOut.getLog());
+ "Checkstyle ends with 2 errors.%n", expectedPath), systemOut.getLog());
assertEquals("", systemErr.getLog());
}
});