From c1ce1f8f0c8c9ef84d71fbe47ea671adcd87043a Mon Sep 17 00:00:00 2001 From: Roman Ivanov Date: Sun, 26 Apr 2015 09:49:35 -0700 Subject: [PATCH] fixed violations for PMD rule UseCollectionIsEmpty. Issue #744 --- config/pmd.xml | 1 - .../checks/coding/VariableDeclarationUsageDistanceCheck.java | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/config/pmd.xml b/config/pmd.xml index f0b439b9c..25a18dae7 100644 --- a/config/pmd.xml +++ b/config/pmd.xml @@ -121,7 +121,6 @@ - diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java index ba8480cc0..a60bafb9b 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheck.java @@ -487,7 +487,7 @@ public class VariableDeclarationUsageDistanceCheck extends Check } // If expression doesn't contain variable and this variable // hasn't been met yet, than distance + 1. - else if (variableUsageExpressions.size() == 0 + else if (variableUsageExpressions.isEmpty() && currentStatementAst.getType() != TokenTypes.VARIABLE_DEF) { dist++;