From c4a7d06206d86f52665eae47af4db28dc59d93a3 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Mon, 24 Aug 2015 22:13:05 +0200 Subject: [PATCH] Rename non-boolean method starting with question word. #1555 Fixes `NonBooleanMethodNameMayNotStartWithQuestion` inspection violations. Description: >Reports non-boolean methods whose names start with a question word. Non-boolean methods that override library methods are ignored by this inspection. --- .../checkstyle/checks/design/VisibilityModifierCheck.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java index 12e7db3ed..823be3487 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java @@ -449,7 +449,7 @@ public class VisibilityModifierCheck */ private boolean hasIgnoreAnnotation(DetailAST variableDef) { final DetailAST firstIgnoreAnnotation = - containsMatchingAnnotation(variableDef); + findMatchingAnnotation(variableDef); return firstIgnoreAnnotation != null; } @@ -751,7 +751,7 @@ public class VisibilityModifierCheck * @return the AST representing the first such annotation or null if * no such annotation was found */ - private DetailAST containsMatchingAnnotation(DetailAST variableDef) { + private DetailAST findMatchingAnnotation(DetailAST variableDef) { DetailAST matchingAnnotation = null; final DetailAST holder = AnnotationUtility.getAnnotationHolder(variableDef);