diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/PackageObjectFactory.java b/src/main/java/com/puppycrawl/tools/checkstyle/PackageObjectFactory.java index 3f36cb1a1..3bf5f815f 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/PackageObjectFactory.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/PackageObjectFactory.java @@ -19,6 +19,7 @@ package com.puppycrawl.tools.checkstyle; +import java.lang.reflect.Constructor; import java.util.Set; import org.apache.commons.logging.Log; @@ -112,7 +113,9 @@ class PackageObjectFactory implements ModuleFactory { throws CheckstyleException { try { final Class clazz = Class.forName(className, true, moduleClassLoader); - return clazz.getDeclaredConstructor().newInstance(); + final Constructor declaredConstructor = clazz.getDeclaredConstructor(); + declaredConstructor.setAccessible(true); + return declaredConstructor.newInstance(); } catch (final ReflectiveOperationException exception) { throw new CheckstyleException("Unable to find class for " + className, exception); diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/gui/FileDrop.java b/src/main/java/com/puppycrawl/tools/checkstyle/gui/FileDrop.java index fa8b9703d..e24b1c378 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/gui/FileDrop.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/gui/FileDrop.java @@ -228,7 +228,7 @@ class FileDrop { * * @since 1.0 */ - public interface Listener { + interface Listener { /** * This method is called when files have been successfully dropped. * diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/gui/JTreeTable.java b/src/main/java/com/puppycrawl/tools/checkstyle/gui/JTreeTable.java index 377f4a192..7ff7d39bf 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/gui/JTreeTable.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/gui/JTreeTable.java @@ -279,7 +279,7 @@ public class JTreeTable extends JTable { * TreeTableCellEditor implementation. Component returned is the * JTree. */ - public class TreeTableCellEditor extends AbstractCellEditor implements + private class TreeTableCellEditor extends AbstractCellEditor implements TableCellEditor { @Override public Component getTableCellEditorComponent(JTable table, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/TreeWalkerTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/TreeWalkerTest.java index 47fbb0f14..9a5aa7b61 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/TreeWalkerTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/TreeWalkerTest.java @@ -294,7 +294,7 @@ public class TreeWalkerTest extends BaseCheckTestSupport { treeWalker.processFiltered(file, lines); } - public static class BadJavaDocCheck extends Check { + private static class BadJavaDocCheck extends Check { @Override public int[] getDefaultTokens() { return getAcceptableTokens(); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java index 3b986d360..6d50dc700 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java @@ -98,7 +98,7 @@ public class AutomaticBeanTest { } @SuppressWarnings("unused") - public static class TestBean extends AutomaticBean { + private static class TestBean extends AutomaticBean { private String privateField; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/FileSetCheckLifecycleTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/FileSetCheckLifecycleTest.java index e6afb194a..9937ba772 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/FileSetCheckLifecycleTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/FileSetCheckLifecycleTest.java @@ -93,7 +93,7 @@ public class FileSetCheckLifecycleTest TestFileSetCheck.isFileContentAvailable()); } - public static class TestFileSetCheck extends AbstractFileSetCheck { + private static class TestFileSetCheck extends AbstractFileSetCheck { private static boolean destroyed; private static boolean fileContentAvailable; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java index 41a83b744..86bad0d9a 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java @@ -81,7 +81,7 @@ public class AbstractJavadocCheckTest extends BaseCheckTestSupport { verify(checker, getPath("javadoc/InputCorrectJavaDocParagraphCheck.java"), expected); } - public static class TempCheck extends AbstractJavadocCheck { + private static class TempCheck extends AbstractJavadocCheck { @Override public int[] getDefaultJavadocTokens() { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocParseTreeTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocParseTreeTest.java index ef6eb1f7a..3e560f61b 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocParseTreeTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocParseTreeTest.java @@ -271,7 +271,7 @@ public class JavadocParseTreeTest { Assert.assertEquals(t1.toStringTree(parser), t2.toStringTree(parser)); } - public static class FailOnErrorListener extends BaseErrorListener { + private static class FailOnErrorListener extends BaseErrorListener { @Override public void syntaxError( Recognizer aRecognizer, Object aOffendingSymbol, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/comments/AllBlockCommentsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/comments/AllBlockCommentsTest.java index 64765a43d..4c3baa0af 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/comments/AllBlockCommentsTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/comments/AllBlockCommentsTest.java @@ -47,7 +47,7 @@ public class AllBlockCommentsTest extends BaseCheckTestSupport { Assert.assertTrue(ALL_COMMENTS.isEmpty()); } - public static class BlockCommentListenerCheck extends Check { + private static class BlockCommentListenerCheck extends Check { @Override public boolean isCommentNodesRequired() { return true; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/comments/AllSinglelineCommentsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/comments/AllSinglelineCommentsTest.java index 6b53989a2..6e0ff03b2 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/comments/AllSinglelineCommentsTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/comments/AllSinglelineCommentsTest.java @@ -46,7 +46,7 @@ public class AllSinglelineCommentsTest extends BaseCheckTestSupport { Assert.assertTrue(ALL_COMMENTS.isEmpty()); } - public static class SinglelineCommentListenerCheck extends Check { + private static class SinglelineCommentListenerCheck extends Check { @Override public boolean isCommentNodesRequired() { return true;