From c67842e01546aefb4231a1ef712f6313a258b41c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20K=C3=BChne?= Date: Wed, 1 Jan 2003 15:53:35 +0000 Subject: [PATCH] prevent duplicate messages --- .../puppycrawl/tools/checkstyle/api/LocalizedMessages.java | 4 +++- .../checkstyle/checks/SimplifyBooleanExpressionCheckTest.java | 2 -- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/api/LocalizedMessages.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/api/LocalizedMessages.java index 468cb4969..d3d1777a4 100644 --- a/src/checkstyle/com/puppycrawl/tools/checkstyle/api/LocalizedMessages.java +++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/api/LocalizedMessages.java @@ -62,7 +62,9 @@ public class LocalizedMessages **/ public void add(LocalizedMessage aMsg) { - mMessages.add(aMsg); + if (!mMessages.contains(aMsg)) { + mMessages.add(aMsg); + } } /** @return the number of messages */ diff --git a/src/tests/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanExpressionCheckTest.java b/src/tests/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanExpressionCheckTest.java index dcb833b5a..efa5dd4e4 100644 --- a/src/tests/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanExpressionCheckTest.java +++ b/src/tests/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanExpressionCheckTest.java @@ -17,8 +17,6 @@ public class SimplifyBooleanExpressionCheckTest "42:36: Expression can be simplified.", "43:16: Expression can be simplified.", "43:32: Expression can be simplified.", - // TODO: Change Check.log to avoid duplicate messages - "43:32: Expression can be simplified.", }; verify(checkConfig, getPath("InputSimplifyBoolean.java"), expected); }