TouchInstinct
/
checkstyle
306
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue #1290: coverage has been increased to 100% in TranslationCheck

This commit is contained in:
Ilja Dubinin 2015-07-26 18:00:37 +01:00 committed by Roman Ivanov
parent 2c6e941a26
commit c6c9ad9d33
2 changed files with 38 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pom.xml
View File

@ -1629,11 +1629,6 @@
<branchRate>75</branchRate>
<lineRate>93</lineRate>
</regex>
<regex>
<pattern>.*.checks.TranslationCheck</pattern>
<branchRate>81</branchRate>
<lineRate>83</lineRate>
</regex>
<regex>
<pattern>.*.checks.header.AbstractHeaderCheck</pattern>

38
src/test/java/com/puppycrawl/tools/checkstyle/checks/TranslationCheckTest.java
View File

@ -22,11 +22,14 @@ package com.puppycrawl.tools.checkstyle.checks;
import static com.puppycrawl.tools.checkstyle.checks.TranslationCheck.MSG_KEY;
import java.io.File;
import java.io.IOException;
import java.lang.reflect.Method;
import org.apache.commons.lang3.ArrayUtils;
import org.junit.Test;
import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport;
import com.puppycrawl.tools.checkstyle.Checker;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
import com.puppycrawl.tools.checkstyle.api.Configuration;
@ -88,4 +91,39 @@ public class TranslationCheckTest
getPath("app-dev.properties"),
expected);
}
@Test
public void testLogIOExceptionFileNotFound() throws Exception {
//I can't put wrong file here. Checkstyle fails before check started.
//I saw some usage of file or handling of wrong file in Checker, or somewhere
//in checks running part. So I had to do it with reflection to improve coverage.
TranslationCheck check = new TranslationCheck();
DefaultConfiguration checkConfig = createCheckConfig(TranslationCheck.class);
check.configure(checkConfig);
Checker checker = createChecker(checkConfig);
check.setMessageDispatcher(checker);
Method loadKeys = check.getClass().getDeclaredMethod("loadKeys", File.class);
loadKeys.setAccessible(true);
loadKeys.invoke(check, new File(""));
}
@Test
public void testLogIOException() throws Exception {
//I can't put wrong file here. Checkstyle fails before check started.
//I saw some usage of file or handling of wrong file in Checker, or somewhere
//in checks running part. So I had to do it with reflection to improve coverage.
TranslationCheck check = new TranslationCheck();
DefaultConfiguration checkConfig = createCheckConfig(TranslationCheck.class);
check.configure(checkConfig);
check.setMessageDispatcher(createChecker(checkConfig));
Method logIOException = check.getClass().getDeclaredMethod("logIOException",
IOException.class,
File.class);
logIOException.setAccessible(true);
logIOException.invoke(check, new IOException(), new File(""));
}
}