Replace `StringBuffer` with `StringBuilder` to improve performance

Thread-safety given by `StringBuffer` doesn't give any benefit when used within one method, so in such cases `StringBuilder` is safe and more efficient replacement.
This commit is contained in:
Michal Kordas 2015-02-15 09:57:43 +01:00
parent a03a2c5c51
commit ca634f7caf
6 changed files with 8 additions and 8 deletions

View File

@ -382,7 +382,7 @@ public class Checker extends AutomaticBean implements MessageDispatcher
dosWithDrive = true;
final char[] ca = path.replace('/', '\\').toCharArray();
final StringBuffer sbRoot = new StringBuffer();
final StringBuilder sbRoot = new StringBuilder();
for (int i = 0; i < colon; i++) {
sbRoot.append(Character.toUpperCase(ca[i]));
}
@ -393,7 +393,7 @@ public class Checker extends AutomaticBean implements MessageDispatcher
root = sbRoot.toString();
// Eliminate consecutive slashes after the drive spec
final StringBuffer sbPath = new StringBuffer();
final StringBuilder sbPath = new StringBuilder();
for (int i = colon + 1; i < ca.length; i++) {
if ((ca[i] != '\\') || ((ca[i] == '\\') && (ca[i - 1] != '\\')))
{
@ -439,7 +439,7 @@ public class Checker extends AutomaticBean implements MessageDispatcher
}
}
final StringBuffer sb = new StringBuffer();
final StringBuilder sb = new StringBuilder();
for (int i = 0; i < s.size(); i++) {
if (i > 1) {
// not before the filesystem root and not after it, since root

View File

@ -460,7 +460,7 @@ public final class ConfigurationLoader
final List<String> propertyRefs = Lists.newArrayList();
parsePropertyString(value, fragments, propertyRefs);
final StringBuffer sb = new StringBuffer();
final StringBuilder sb = new StringBuilder();
final Iterator<String> i = fragments.iterator();
final Iterator<String> j = propertyRefs.iterator();
while (i.hasNext()) {

View File

@ -103,7 +103,7 @@ public class DefaultLogger
// avoid StringBuffer.expandCapacity
final int bufLen = fileName.length() + message.length()
+ BUFFER_CUSHION;
final StringBuffer sb = new StringBuffer(bufLen);
final StringBuilder sb = new StringBuilder(bufLen);
sb.append(fileName);
sb.append(':').append(evt.getLine());

View File

@ -107,7 +107,7 @@ public final class PackageNamesLoader
*/
private String getPackageName()
{
final StringBuffer buf = new StringBuffer();
final StringBuilder buf = new StringBuilder();
for (String subPackage : packageStack) {
buf.append(subPackage);
if (!subPackage.endsWith(".")) {

View File

@ -222,7 +222,7 @@ final class PropertyCacheFile
*/
private static String hexEncode(byte[] byteArray)
{
final StringBuffer buf = new StringBuffer(2 * byteArray.length);
final StringBuilder buf = new StringBuilder(2 * byteArray.length);
for (final byte b : byteArray) {
final int low = b & MASK_0X0F;
final int high = (b >> SHIFT_4) & MASK_0X0F;

View File

@ -170,7 +170,7 @@ public class XMLLogger
*/
public String encode(String value)
{
final StringBuffer sb = new StringBuffer();
final StringBuilder sb = new StringBuilder();
for (int i = 0; i < value.length(); i++) {
final char c = value.charAt(i);
switch (c) {