From cb5f9827e5ee8bd134452862c8eb526554e8f2c2 Mon Sep 17 00:00:00 2001
From: Roman Ivanov <ivanov-jr@mail.ru>
Date: Sat, 25 Apr 2015 23:46:48 -0700
Subject: [PATCH] activation and suppression comments for PMD design rules.
 Issue #744

---
 config/pmd.xml | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/config/pmd.xml b/config/pmd.xml
index b562e4a6d..55e45a70c 100644
--- a/config/pmd.xml
+++ b/config/pmd.xml
@@ -115,29 +115,20 @@
     <exclude name="ImmutableField"/>
     <!-- this rule does not have any option, unreasonable to use -->
     <exclude name="MissingBreakInSwitch"/>
-    <exclude name="SimplifyConditional"/>
+    <!-- we need compare by ref as Tree structure is immutable, we can easily rely on refs -->
     <exclude name="CompareObjectsWithEquals"/>
-    <exclude name="PositionLiteralsFirstInComparisons"/>
-    <exclude name="PositionLiteralsFirstInCaseInsensitiveComparisons"/>
-    <exclude name="UnnecessaryLocalBeforeReturn"/>
-    <exclude name="NonThreadSafeSingleton"/>
     <exclude name="UncommentedEmptyMethod"/>
-    <exclude name="UncommentedEmptyConstructor"/>
-    <exclude name="AvoidConstantsInterface"/>
-    <exclude name="UnsynchronizedStaticDateFormatter"/>
     <exclude name="PreserveStackTrace"/>
     <exclude name="UseCollectionIsEmpty"/>
-    <exclude name="ClassWithOnlyPrivateConstructorsShouldBeFinal"/>
     <exclude name="EmptyMethodInAbstractClassShouldBeAbstract"/>
     <exclude name="SingularField"/>
-    <exclude name="ReturnEmptyArrayRatherThanNull"/>
-    <exclude name="AbstractClassWithoutAnyMethod"/>
     <exclude name="TooFewBranchesForASwitchStatement"/>
     <exclude name="LogicInversion"/>
     <exclude name="UseVarargs"/>
+    <!-- we will use our own declaration order logic -->
     <exclude name="FieldDeclarationsShouldBeAtStartOfClass"/>
+    <!-- too much alarms of Checks, we will never move logic out of Check, each Check is independed logic contianer -->
     <exclude name="GodClass"/>
-    <exclude name="AvoidProtectedMethodInFinalClassNotExtending"/>
   </rule>
   <rule ref="rulesets/java/design.xml/AvoidDeeplyNestedIfStmts">
     <properties>