From ce4df1ec00d6eaa2547b9c1bdcbeec2b22f0fe0f Mon Sep 17 00:00:00 2001 From: Ilja Dubinin Date: Tue, 29 Sep 2015 22:40:17 +0100 Subject: [PATCH] Issue #1290: Coverage has been increased to 100% in AbstractDeclarationCollector. --- pom.xml | 5 ---- .../checks/coding/RequireThisCheckTest.java | 9 +++++++ .../checkstyle/coding/InputRequireThis3.java | 24 +++++++++++++++++++ 3 files changed, 33 insertions(+), 5 deletions(-) create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/coding/InputRequireThis3.java diff --git a/pom.xml b/pom.xml index 31c99a151..539ca9f35 100644 --- a/pom.xml +++ b/pom.xml @@ -1661,11 +1661,6 @@ 89 95 - - .*.checks.AbstractDeclarationCollector - 94 - 100 - .*.checks.SuppressWarningsHolder 86 diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java index a21b19bbf..3450f4aea 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java @@ -105,4 +105,13 @@ public class RequireThisCheckTest extends BaseCheckTestSupport { Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); } + + @Test + public void testWithAnnonymousClass() throws Exception { + final DefaultConfiguration checkConfig = createCheckConfig(RequireThisCheck.class); + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + verify(checkConfig, + getPath("coding" + File.separator + "InputRequireThis3.java"), + expected); + } } diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/coding/InputRequireThis3.java b/src/test/resources/com/puppycrawl/tools/checkstyle/coding/InputRequireThis3.java new file mode 100644 index 000000000..4d326a652 --- /dev/null +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/coding/InputRequireThis3.java @@ -0,0 +1,24 @@ +package com.puppycrawl.tools.checkstyle.checks.coding; + +public class InputRequireThis3 { + interface AnonWithEmpty { + public void fooEmpty(); + } + + void method() { + AnonWithEmpty foo = new AnonWithEmpty() { + + public void emptyMethod() { + } + + @Override + public void fooEmpty() { + int a = doSideEffect(); + } + + public int doSideEffect() { + return 1; + } + }; + } +}