TouchInstinct
/
checkstyle
306
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor: fix for IntelijIdea inspection violations

This commit is contained in:
Roman Ivanov 2016-06-23 06:41:32 -07:00
parent f859a312c2
commit ce5574b3f4
2 changed files with 20 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/java/com/puppycrawl/tools/checkstyle/checks/UniquePropertiesCheckTest.java
View File

@ -114,7 +114,7 @@ public class UniquePropertiesCheckTest extends BaseFileSetCheckTestSupport {
getPath("InputUniquePropertiesCheckNotExisting.properties");
final File file = new File(fileName);
final SortedSet<LocalizedMessage> messages =
check.process(file, Collections.<String>emptyList());
check.process(file, Collections.emptyList());
assertEquals("Wrong messages count: " + messages.size(),
1, messages.size());
final LocalizedMessage message = messages.iterator().next();

32
src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressElementTest.java
View File

@ -21,6 +21,7 @@ package com.puppycrawl.tools.checkstyle.filters;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertTrue;
import org.junit.Before;
@ -160,27 +161,32 @@ public class SuppressElementTest {
@Test
public void testEquals() {
// filterBased is used instead of filter field only to satisfy IntelijIdea Inspection
// Inspection "Arguments to assertEquals() in wrong order "
final SuppressElement filterBased = new SuppressElement("Test");
filterBased.setChecks("Test");
final SuppressElement filter2 = new SuppressElement("Test");
filter2.setChecks("Test");
assertEquals("filter, filter2", filter, filter2);
assertEquals("filter, filter2", filterBased, filter2);
final SuppressElement filter3 = new SuppressElement("Test");
filter3.setChecks("Test3");
assertFalse("filter, filter3", filter.equals(filter3));
filter.setColumns("1-10");
assertFalse("filter, filter2", filter.equals(filter2));
assertNotEquals("filter, filter3", filterBased, filter3);
filterBased.setColumns("1-10");
assertNotEquals("filter, filter2", filterBased, filter2);
filter2.setColumns("1-10");
assertEquals("filter, filter2", filter, filter2);
filter.setColumns(null);
assertFalse("filter, filter2", filter.equals(filter2));
assertEquals("filter, filter2", filterBased, filter2);
filterBased.setColumns(null);
assertNotEquals("filter, filter2", filterBased, filter2);
filter2.setColumns(null);
filter.setLines("3,4");
assertFalse("filter, filter2", filter.equals(filter2));
filterBased.setLines("3,4");
assertNotEquals("filter, filter2", filterBased, filter2);
filter2.setLines("3,4");
assertEquals("filter, filter2", filter, filter2);
filter.setColumns("1-10");
assertFalse("filter, filter2", filter.equals(filter2));
assertEquals("filter, filter2", filterBased, filter2);
filterBased.setColumns("1-10");
assertNotEquals("filter, filter2", filterBased, filter2);
filter2.setColumns("1-10");
assertEquals("filter, filter2", filter, filter2);
assertEquals("filter, filter2", filterBased, filter2);
}
@Test