From cf5686783fed5f7598da0be118391f930e5a2ef7 Mon Sep 17 00:00:00 2001 From: alexkravin Date: Fri, 12 Dec 2014 16:57:58 +0400 Subject: [PATCH] Fixed false-positive in GenericWhitespaceCheck issue #51 --- .../checks/whitespace/GenericWhitespaceCheck.java | 5 +---- .../checks/whitespace/GenericWhitespaceCheckTest.java | 10 ++++++++++ .../InputGenericWhitespaceInnerClassCheck.java | 11 +++++++++++ 3 files changed, 22 insertions(+), 4 deletions(-) create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/whitespace/InputGenericWhitespaceInnerClassCheck.java diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheck.java index 8849eb1a3..8031bcc27 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheck.java @@ -161,10 +161,7 @@ public class GenericWhitespaceCheck extends Check log(aAST.getLineNo(), after, "ws.followed", ">"); } } - else if ((line.charAt(after) != '>') - && (line.charAt(after) != ',') - && (line.charAt(after) != '[')) - { + else if (line.charAt(after) == ' ') { log(aAST.getLineNo(), after, "ws.followed", ">"); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheckTest.java index 7460696fb..afbab3915 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheckTest.java @@ -83,4 +83,14 @@ public class GenericWhitespaceCheckTest final String[] expected = {}; verify(mCheckConfig, getPath("whitespace/Gh47.java"), expected); } + + @Test + public void testInnerClass() throws Exception + { + final String[] expected = { + + }; + verify(mCheckConfig, getPath("whitespace/" + + "InputGenericWhitespaceInnerClassCheck.java"), expected); + } } diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/whitespace/InputGenericWhitespaceInnerClassCheck.java b/src/test/resources/com/puppycrawl/tools/checkstyle/whitespace/InputGenericWhitespaceInnerClassCheck.java new file mode 100644 index 000000000..584410bc8 --- /dev/null +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/whitespace/InputGenericWhitespaceInnerClassCheck.java @@ -0,0 +1,11 @@ +package com.puppycrawl.tools.checkstyle.whitespace; + +import java.util.List; + +public class InputGenericWhitespaceInnerClassCheck +{ + private List.InnerClass> field; + + public class InnerClass { + } +}