From d0fbb100b68800de625f53db27e6296beda76cc4 Mon Sep 17 00:00:00 2001 From: Rick Giles Date: Mon, 30 Jun 2003 23:49:37 +0000 Subject: [PATCH] added check for FinderException throws clause to ejbSelect check --- .../checkstyle/checks/j2ee/EntityBeanEjbSelectCheck.java | 5 +++++ contrib/j2ee/src/tests/EntityBeanEjbSelectCheckTest.java | 1 + 2 files changed, 6 insertions(+) diff --git a/contrib/j2ee/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/j2ee/EntityBeanEjbSelectCheck.java b/contrib/j2ee/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/j2ee/EntityBeanEjbSelectCheck.java index ad83550e3..02b171e35 100644 --- a/contrib/j2ee/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/j2ee/EntityBeanEjbSelectCheck.java +++ b/contrib/j2ee/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/j2ee/EntityBeanEjbSelectCheck.java @@ -52,6 +52,11 @@ public class EntityBeanEjbSelectCheck log(nameAST.getLineNo(), nameAST.getColumnNo(), "nonabstract.bean", "Method " + name); } + if (!Utils.hasThrows(aAST, "javax.ejb.FinderException")) { + log(nameAST.getLineNo(), nameAST.getColumnNo(), + "missingthrows.bean", + new Object[] {name, "javax.ejb.FinderException"}); + } } } } diff --git a/contrib/j2ee/src/tests/EntityBeanEjbSelectCheckTest.java b/contrib/j2ee/src/tests/EntityBeanEjbSelectCheckTest.java index 3f7b48391..c8386f6c0 100644 --- a/contrib/j2ee/src/tests/EntityBeanEjbSelectCheckTest.java +++ b/contrib/j2ee/src/tests/EntityBeanEjbSelectCheckTest.java @@ -15,6 +15,7 @@ public class EntityBeanEjbSelectCheckTest extends BaseCheckTestCase "110:33: Method ejbSelectSomething must be public.", "110:33: Method ejbSelectSomething must not have modifier final.", "110:33: Method ejbSelectSomething must not have modifier static.", + "110:33: Method ejbSelectSomething must throw javax.ejb.FinderException.", }; verify(checkConfig, getPath("InputEntityBean.java"), expected); }