Pull #3412: Disallow usage of java.util.Stack, java.util.Vector in code, 'checks' package in 'api' and 'utils' packages (#3412)

This commit is contained in:
Andrei Selkin 2016-09-09 01:50:23 +04:00 committed by Roman Ivanov
parent 230919ee09
commit d563f0060c
3 changed files with 16 additions and 5 deletions

View File

@ -87,8 +87,14 @@
<property name="requiredParameters" value="value"/>
</module>
<module name="ForbidCertainImports">
<property name="packageNameRegexp" value="^.*(api|utils).*$"/>
<property name="forbiddenImportsRegexp" value="^.*checks.*|java\.util\.Vector|java\.util\.Stack$"/>
<property name="packageNameRegexp" value=".+"/>
<property name="forbiddenImportsRegexp" value="java\.util\.Stack|java\.util\.Vector"/>
<property name="forbiddenImportsExcludesRegexp" value=""/>
</module>
<module name="ForbidCertainImports">
<property name="packageNameRegexp" value=".+\.checkstyle\.api.*|.+\.checkstyle\.utils.*"/>
<property name="forbiddenImportsRegexp" value=".+\.checks\..+"/>
<property name="forbiddenImportsExcludesRegexp" value=""/>
</module>
<module name="LineLengthExtended">
<property name="max" value="100"/>

View File

@ -56,4 +56,11 @@
<suppress checks="IllegalCatchExtended"
files="CheckerTest\.java"
lines="543"/>
<!--JavadocTagInfo.java, JavadocTags.java, InvalidJavadocTag.java, JavadocTag.java will be
deprecated as we completely switch to ANTLR parser for javadoc. All of the mentioned classes
are required only for old javadoc parsers and their usage will be excluded from
JavadocUtils.java and JavadocUtilsTest.java. -->
<suppress checks="ForbidCertainImports"
files="JavadocUtils\.java|JavadocUtilsTest\.java"/>
</suppressions>

View File

@ -19,14 +19,12 @@
package com.puppycrawl.tools.checkstyle.api;
import com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocNodeImpl;
/**
* DetailNode is used to construct tree during parsing Javadoc comments.
* Contains array of children, parent node and other useful fields.
*
* @author Baratali Izmailov
* @see JavadocNodeImpl
* @see com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocNodeImpl
* @see com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocCheck
*/
public interface DetailNode {