diff --git a/pom.xml b/pom.xml
index 3b9d6c3d7..882c3aaab 100644
--- a/pom.xml
+++ b/pom.xml
@@ -665,7 +665,6 @@
.*.api.DetailAST9598
.*.api.FileContents9694
.*.api.FileText5059
- .*.api.FilterSet8380
.*.api.FullIdent8396
.*.api.JavadocTagInfo2577
.*.api.JavadocTagInfo\$.*08
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/api/FilterSet.java b/src/main/java/com/puppycrawl/tools/checkstyle/api/FilterSet.java
index 4b989ce8a..91b89a930 100644
--- a/src/main/java/com/puppycrawl/tools/checkstyle/api/FilterSet.java
+++ b/src/main/java/com/puppycrawl/tools/checkstyle/api/FilterSet.java
@@ -20,6 +20,8 @@
package com.puppycrawl.tools.checkstyle.api;
import com.google.common.collect.Sets;
+
+import java.util.Objects;
import java.util.Set;
/**
@@ -49,31 +51,21 @@ public class FilterSet
filters.remove(filter);
}
- /**
- * Returns the Filters of the filter set.
- * @return the Filters of the filter set.
- */
- protected Set getFilters() {
- return filters;
- }
-
@Override
- public String toString() {
- return filters.toString();
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ final FilterSet filterSet = (FilterSet) o;
+ return Objects.equals(filters, filterSet.filters);
}
@Override
public int hashCode() {
- return filters.hashCode();
- }
-
- @Override
- public boolean equals(Object object) {
- if (object instanceof FilterSet) {
- final FilterSet other = (FilterSet) object;
- return this.filters.equals(other.filters);
- }
- return false;
+ return Objects.hash(filters);
}
/** {@inheritDoc} */
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/filters/FilterSetTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/filters/FilterSetTest.java
index da7813cb9..110bed1b8 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/filters/FilterSetTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/filters/FilterSetTest.java
@@ -21,6 +21,9 @@ package com.puppycrawl.tools.checkstyle.filters;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
+
+import com.puppycrawl.tools.checkstyle.api.FilterSet;
+import nl.jqno.equalsverifier.EqualsVerifier;
import org.junit.Before;
import org.junit.Test;
@@ -54,4 +57,9 @@ public class FilterSetTest {
filter.addFilter(new IntRangeFilter(3, 4));
assertTrue("0 is in [3,4]", filter.accept(Integer.valueOf(0)));
}
+
+ @Test
+ public void testEqualsAndHashCode() {
+ EqualsVerifier.forClass(FilterSet.class).usingGetClass().verify();
+ }
}