From d938bf243b995b18a52ebbbd552497c78c6e5e30 Mon Sep 17 00:00:00 2001
From: Aleksandr Ivanov <ivanov-alex@yandex.ru>
Date: Mon, 15 Jun 2015 21:58:25 +0300
Subject: [PATCH] UT coverage for AvoidStarImportCheck. #1128

---
 pom.xml                                             |  2 --
 .../checks/imports/AvoidStarImportCheck.java        | 13 +++----------
 2 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/pom.xml b/pom.xml
index 4a0ee3fe1..de316cff1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -813,8 +813,6 @@
           <regex><pattern>.*.checks.header.RegexpHeaderCheck</pattern><branchRate>87</branchRate><lineRate>93</lineRate></regex>
 
 
-          <regex><pattern>.*.checks.imports.AvoidStarImportCheck</pattern><branchRate>95</branchRate><lineRate>100</lineRate></regex>
-          <regex><pattern>.*.checks.imports.AvoidStaticImportCheck</pattern><branchRate>91</branchRate><lineRate>100</lineRate></regex>
           <regex><pattern>.*.checks.imports.CustomImportOrderCheck</pattern><branchRate>93</branchRate><lineRate>91</lineRate></regex>
           <regex><pattern>.*.checks.imports.Guard</pattern><branchRate>86</branchRate><lineRate>100</lineRate></regex>
           <regex><pattern>.*.checks.imports.ImportControlCheck</pattern><branchRate>85</branchRate><lineRate>73</lineRate></regex>
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportCheck.java
index 582685a34..08e400c0e 100644
--- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportCheck.java
+++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportCheck.java
@@ -154,17 +154,10 @@ public class AvoidStarImportCheck
      */
     private void logsStarredImportViolation(DetailAST startingDot) {
         final FullIdent name = FullIdent.createFullIdent(startingDot);
-        if (isStaredImport(name) && !excludes.contains(name.getText())) {
-            log(startingDot.getLineNo(), MSG_KEY, name.getText());
+        final String importText = name.getText();
+        if (importText.endsWith(".*") && !excludes.contains(importText)) {
+            log(startingDot.getLineNo(), MSG_KEY, importText);
         }
     }
 
-    /**
-     * Checks is an import is a stared import.
-     * @param importIdent the full import identifier
-     * @return true if a start import false if not
-     */
-    private boolean isStaredImport(FullIdent importIdent) {
-        return null != importIdent && importIdent.getText().endsWith(".*");
-    }
 }