From de4485a22bfe8eafc3c2e273fd328a0221d0ff9e Mon Sep 17 00:00:00 2001 From: alexkravin Date: Wed, 4 Mar 2015 00:09:17 +0400 Subject: [PATCH] Visibility Modifier Check, updated option setter, issue #710 --- .../checks/design/VisibilityModifierCheck.java | 2 +- .../checks/design/VisibilityModifierCheckTest.java | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java index 40d5a8ca3..855373668 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java @@ -293,7 +293,7 @@ public class VisibilityModifierCheck * Set the list of immutable classes types names. * @param classNames array of immutable types short names. */ - public void setImmutableClassNames(String[] classNames) + public void setImmutableClassCanonicalNames(String[] classNames) { immutableClassCanonicalNames = Arrays.asList(classNames); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java index 0f08d292f..2d9304232 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java @@ -113,7 +113,7 @@ public class VisibilityModifierCheckTest { final DefaultConfiguration checkConfig = createCheckConfig(VisibilityModifierCheck.class); - checkConfig.addAttribute("immutableClassNames", "java.util.List," + checkConfig.addAttribute("immutableClassCanonicalNames", "java.util.List," + "com.google.common.collect.ImmutableSet"); final String[] expected = { "14:35: " + getCheckMessage(MSG_KEY, "notes"), @@ -133,7 +133,7 @@ public class VisibilityModifierCheckTest { final DefaultConfiguration checkConfig = createCheckConfig(VisibilityModifierCheck.class); - checkConfig.addAttribute("immutableClassNames", + checkConfig.addAttribute("immutableClassCanonicalNames", "com.puppycrawl.tools.checkstyle.coding.GregorianCalendar," + "com.puppycrawl.tools.checkstyle.InetSocketAddress"); final String[] expected = { @@ -162,7 +162,7 @@ public class VisibilityModifierCheckTest { final DefaultConfiguration checkConfig = createCheckConfig(VisibilityModifierCheck.class); - checkConfig.addAttribute("immutableClassNames", "java.util.Arrays"); + checkConfig.addAttribute("immutableClassCanonicalNames", "java.util.Arrays"); final String[] expected = { }; verify(checkConfig, getPath("InputImmutableStarImport.java"), expected); @@ -173,7 +173,8 @@ public class VisibilityModifierCheckTest { final DefaultConfiguration checkConfig = createCheckConfig(VisibilityModifierCheck.class); - checkConfig.addAttribute("immutableClassNames", "com.google.common.collect.ImmutableSet"); + checkConfig.addAttribute("immutableClassCanonicalNames", + "com.google.common.collect.ImmutableSet"); final String[] expected = { }; verify(checkConfig, getPath("InputImmutableStarImport2.java"), expected);