diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/api/Check.java b/src/main/java/com/puppycrawl/tools/checkstyle/api/Check.java index bc688a554..5f901cd2d 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/api/Check.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/api/Check.java @@ -18,6 +18,7 @@ //////////////////////////////////////////////////////////////////////////////// package com.puppycrawl.tools.checkstyle.api; +import java.util.Collections; import java.util.Set; import com.google.common.collect.Sets; @@ -98,9 +99,7 @@ public abstract class Check extends AbstractViolationReporter */ public final void setTokens(String[] strRep) { - for (final String s : strRep) { - tokens.add(s); - } + Collections.addAll(tokens, strRep); } /** diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalThrowsCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalThrowsCheck.java index 668af8316..0f9d63558 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalThrowsCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalThrowsCheck.java @@ -23,6 +23,8 @@ import com.puppycrawl.tools.checkstyle.api.AnnotationUtility; import com.puppycrawl.tools.checkstyle.api.DetailAST; import com.puppycrawl.tools.checkstyle.api.FullIdent; import com.puppycrawl.tools.checkstyle.api.TokenTypes; + +import java.util.Collections; import java.util.Set; /** @@ -139,9 +141,7 @@ public final class IllegalThrowsCheck extends AbstractIllegalCheck public void setIgnoredMethodNames(String[] methodNames) { ignoredMethodNames.clear(); - for (String element : methodNames) { - ignoredMethodNames.add(element); - } + Collections.addAll(ignoredMethodNames, methodNames); } /** diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheck.java index 07838012c..5000a3a6f 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheck.java @@ -26,6 +26,7 @@ import com.puppycrawl.tools.checkstyle.checks.AbstractFormatCheck; import com.puppycrawl.tools.checkstyle.checks.CheckUtils; import java.util.ArrayList; +import java.util.Collections; import java.util.List; import java.util.Set; @@ -397,9 +398,7 @@ public final class IllegalTypeCheck extends AbstractFormatCheck public void setIllegalClassNames(String[] classNames) { illegalClassNames.clear(); - for (String name : classNames) { - illegalClassNames.add(name); - } + Collections.addAll(illegalClassNames, classNames); } /** @@ -419,9 +418,7 @@ public final class IllegalTypeCheck extends AbstractFormatCheck public void setIgnoredMethodNames(String[] methodNames) { ignoredMethodNames.clear(); - for (String element : methodNames) { - ignoredMethodNames.add(element); - } + Collections.addAll(ignoredMethodNames, methodNames); } /** @@ -441,9 +438,7 @@ public final class IllegalTypeCheck extends AbstractFormatCheck public void setLegalAbstractClassNames(String[] classNames) { legalAbstractClassNames.clear(); - for (String element : classNames) { - legalAbstractClassNames.add(element); - } + Collections.addAll(legalAbstractClassNames, classNames); } /** diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AtclauseOrderCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AtclauseOrderCheck.java index 68340a595..0f1037926 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AtclauseOrderCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AtclauseOrderCheck.java @@ -20,6 +20,7 @@ package com.puppycrawl.tools.checkstyle.checks.javadoc; import java.util.ArrayList; import java.util.Arrays; +import java.util.Collections; import java.util.List; import com.puppycrawl.tools.checkstyle.api.DetailAST; @@ -111,9 +112,7 @@ public class AtclauseOrderCheck extends AbstractJavadocCheck public void setTagOrder(String order) { final List customOrder = new ArrayList(); - for (String type : order.split(", ")) { - customOrder.add(type); - } + Collections.addAll(customOrder, order.split(", ")); tagOrder = customOrder; } diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java index 2b165b166..93bae49fd 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java @@ -36,6 +36,7 @@ import com.puppycrawl.tools.checkstyle.checks.CheckUtils; import java.util.ArrayList; import java.util.Arrays; +import java.util.Collections; import java.util.Iterator; import java.util.List; import java.util.ListIterator; @@ -186,9 +187,7 @@ public class JavadocMethodCheck extends AbstractTypeAwareCheck public void setAllowedAnnotations(String userAnnotations) { final List annotations = new ArrayList(); - for (String annotation : userAnnotations.split(", ")) { - annotations.add(annotation); - } + Collections.addAll(annotations, userAnnotations.split(", ")); allowedAnnotations = annotations; }