TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

handle anonymous classes with CovariantEqualsCheck

This commit is contained in:
Rick Giles 2003-06-26 17:25:02 +00:00
parent 9309a78471
commit e03dd7a0a0
2 changed files with 95 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

116
src/checkstyle/com/puppycrawl/tools/checkstyle/checks/coding/CovariantEqualsCheck.java
View File

@ -56,6 +56,9 @@ public class CovariantEqualsCheck
*/
private class ClassAttributes
{
/** root AST node for class definition */
private DetailAST mRootAST;
/** Set of AST nodes for defined equals methods.
* Empty if the class defines method equals(java.lang.Object)
*/
@ -64,6 +67,24 @@ public class CovariantEqualsCheck
/** true if class defines method equals(java.lang.Object) */
private boolean mHasEqualsObject = false;
/**
* Constructs a ClassAttributes for a class definition.
* @param aAST the root AST node for the class definition.
*/
public ClassAttributes(DetailAST aAST)
{
mRootAST = aAST;
}
/**
* Returns the root AST for the class definition.
* @return the root AST for the class definition.
*/
public DetailAST getRootAST()
{
return mRootAST;
}
/**
* Adds a AST node for the definition of an equals method.
* @param aAST the node of an equals method definition.
@ -101,6 +122,7 @@ public class CovariantEqualsCheck
{
return new int[] {
TokenTypes.CLASS_DEF,
TokenTypes.LITERAL_NEW,
TokenTypes.METHOD_DEF,
};
}
@ -110,7 +132,7 @@ public class CovariantEqualsCheck
{
return getDefaultTokens();
}
/** @see com.puppycrawl.tools.checkstyle.api.Check */
public void beginTree(DetailAST aRootAST)
{
@ -120,25 +142,59 @@ public class CovariantEqualsCheck
/** @see com.puppycrawl.tools.checkstyle.api.Check */
public void visitToken(DetailAST aAST)
{
if (aAST.getType() == TokenTypes.CLASS_DEF) {
//push
mClassStack.add(new ClassAttributes());
}
else {
// METHOD_DEF
if (!ScopeUtils.inInterfaceBlock(aAST) && isEqualsMethod(aAST)) {
final ClassAttributes attrs =
(ClassAttributes) mClassStack.getLast();
if (hasObjectParameter(aAST)) {
attrs.setHasEqualsObject();
if (aAST.getType() == TokenTypes.METHOD_DEF) {
final DetailAST definer = getDefiner(aAST);
final int type = definer.getType();
if ((type == TokenTypes.CLASS_DEF)
|| (type == TokenTypes.LITERAL_NEW))
{
if (mClassStack.isEmpty()) {
mClassStack.add(new ClassAttributes(definer));
}
else {
attrs.addEqualsNode(aAST);
final ClassAttributes attrs =
(ClassAttributes) mClassStack.getLast();
final DetailAST currentRoot = attrs.getRootAST();
if (definer != currentRoot) {
mClassStack.add(new ClassAttributes(definer));
}
if (!ScopeUtils.inInterfaceBlock(aAST)
&& isEqualsMethod(aAST))
{
if (hasObjectParameter(aAST)) {
attrs.setHasEqualsObject();
}
else {
attrs.addEqualsNode(aAST);
}
}
}
}
}
/**
* Determines the definer of an AST node. The definer is a class,
* interface or new (anonymous class).
* @param aAST the defined AST node.
* @return the definer of aAST.
*/
private DetailAST getDefiner(DetailAST aAST)
{
for (DetailAST token = aAST.getParent();
token != null;
token = token.getParent())
{
final int type = token.getType();
if ((type == TokenTypes.CLASS_DEF)
|| (type == TokenTypes.INTERFACE_DEF)
|| (type == TokenTypes.LITERAL_NEW))
{
return token;
}
}
return null;
}
/**
* Tests whether a method definition AST defines an equals covariant.
* @param aAST the method definition AST to test.
@ -196,18 +252,26 @@ public class CovariantEqualsCheck
/** @see com.puppycrawl.tools.checkstyle.api.Check */
public void leaveToken(DetailAST aAST)
{
if (aAST.getType() == TokenTypes.CLASS_DEF) {
//pop and report equals errors
final ClassAttributes attrs =
(ClassAttributes) mClassStack.removeLast();
final Set equalsNodes = attrs.getEqualsNodes();
final Iterator it = equalsNodes.iterator();
while (it.hasNext()) {
final DetailAST equalsAST = (DetailAST) it.next();
final DetailAST nameNode =
equalsAST.findFirstToken(TokenTypes.IDENT);
log(nameNode.getLineNo(), nameNode.getColumnNo(),
"covariant.equals");
final int type = aAST.getType();
if ((type == TokenTypes.LITERAL_NEW)
|| (type == TokenTypes.CLASS_DEF))
{
// pop class stack
if (!mClassStack.isEmpty()) {
final ClassAttributes attrs =
(ClassAttributes) mClassStack.getLast();
if (attrs.getRootAST() == aAST) {
mClassStack.removeLast();
final Set equalsNodes = attrs.getEqualsNodes();
final Iterator it = equalsNodes.iterator();
while (it.hasNext()) {
final DetailAST equalsAST = (DetailAST) it.next();
final DetailAST nameNode =
equalsAST.findFirstToken(TokenTypes.IDENT);
log(nameNode.getLineNo(), nameNode.getColumnNo(),
"covariant.equals");
}
}
}
}
}

5
src/testinputs/com/puppycrawl/tools/checkstyle/InputCovariant.java
View File

@ -80,6 +80,11 @@ class Anonymous
return false;
}
};
public boolean equals(Object aObject)
{
return false;
}
}
abstract class InputCovariant5