From e1a2e66b262be83708d65b7c5f2ba4014c97e384 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Sun, 30 Aug 2015 10:49:08 +0200 Subject: [PATCH] Issue #1555: Replace while with foreach Fixes `WhileCanBeForeach` inspection violation. Description: >Reports while loops which iterate over collections, and can be replaced with the foreach iteration syntax, which is available in Java 5 and newer. This inspection only reports if the project or module is configured to use a language level of 5.0 or higher. --- .../checkstyle/checks/javadoc/JavadocMethodCheck.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java index da9fcd470..8ffb164a3 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java @@ -497,11 +497,9 @@ public class JavadocMethodCheck extends AbstractTypeAwareCheck { } // Dump out all unused tags - final Iterator unusedTagIt = tags.iterator(); - while (unusedTagIt.hasNext()) { - final JavadocTag jt = unusedTagIt.next(); - if (!jt.isSeeOrInheritDocTag()) { - log(jt.getLineNo(), MSG_UNUSED_TAG_GENERAL); + for (JavadocTag javadocTag : tags) { + if (!javadocTag.isSeeOrInheritDocTag()) { + log(javadocTag.getLineNo(), MSG_UNUSED_TAG_GENERAL); } } }