From e89837b42ece86ae3a0efc8ba272f550c98cd33c Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Sun, 30 Aug 2015 10:53:55 +0200 Subject: [PATCH] Issue #1555: Mark methods as static Fixes `MethodMayBeStatic` inspection violation. Description: >Reports any methods which may safely be made static. A method may be static if it is not synchronized, it does not reference any of its class' non static methods and non static fields and is not overridden in a sub class. --- .../java/com/puppycrawl/tools/checkstyle/api/DetailAST.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/api/DetailAST.java b/src/main/java/com/puppycrawl/tools/checkstyle/api/DetailAST.java index 08c0d77e5..bdb846ac8 100755 --- a/src/main/java/com/puppycrawl/tools/checkstyle/api/DetailAST.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/api/DetailAST.java @@ -266,7 +266,7 @@ public final class DetailAST extends CommonASTWithHiddenTokens { * @param ast DetailAST node. * @return Column number if non-comment node exists, -1 otherwise. */ - private int findColumnNo(DetailAST ast) { + private static int findColumnNo(DetailAST ast) { int resultNo = -1; DetailAST node = ast; while (node != null) { @@ -288,7 +288,7 @@ public final class DetailAST extends CommonASTWithHiddenTokens { * @param ast DetailAST node. * @return Line number if non-comment node exists, -1 otherwise. */ - private int findLineNo(DetailAST ast) { + private static int findLineNo(DetailAST ast) { int resultNo = -1; DetailAST node = ast; while (node != null) {