From ea01eaaa85409442aeece8763f0388066bd07bf5 Mon Sep 17 00:00:00 2001
From: Oliver Burn <oliver@puppycrawl.com>
Date: Wed, 6 Feb 2002 21:55:08 +0000
Subject: [PATCH] Just tweaked the style a bit to be consistent with else
 where. I kept the braces on a new line though. ;-)

---
 .../puppycrawl/tools/checkstyle/Checker.java  | 43 ++++++++++---------
 1 file changed, 22 insertions(+), 21 deletions(-)

diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/Checker.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/Checker.java
index 99dc32350..ae57548f8 100644
--- a/src/checkstyle/com/puppycrawl/tools/checkstyle/Checker.java
+++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/Checker.java
@@ -191,31 +191,32 @@ public class Checker
      */
     private int checkPackageHtml(String[] aFiles)
     {
-        int packageHtmlErrors = 0;
-
-        if (aFiles != null && mConfig.isRequirePackageHtml())
+        if (!mConfig.isRequirePackageHtml())
         {
-            final HashSet checkedPackages = new HashSet();
-            for (int i = 0; i < aFiles.length; i++)
+            return 0;
+        }
+
+        int packageHtmlErrors = 0;
+        final HashSet checkedPackages = new HashSet();
+        for (int i = 0; i < aFiles.length; i++)
+        {
+            final File file = new File(aFiles[i]);
+            final File packageDir = file.getParentFile();
+            if (!checkedPackages.contains(packageDir))
             {
-                final File file = new File(aFiles[i]);
-                final File packageDir = file.getParentFile();
-                if (!checkedPackages.contains(packageDir))
+                final File packageDoc =
+                    new File(packageDir, "package.html");
+                final String docFile = packageDoc.toString();
+                fireFileStarted(docFile);
+                if (!packageDoc.exists())
                 {
-                    final File packageDoc =
-                        new File(packageDir, "package.html");
-                    final String docFile = packageDoc.toString();
-                    fireFileStarted(docFile);
-                    if (!packageDoc.exists())
-                    {
-                        final LineText error = new LineText(0,
-                            "missing package documentation file.");
-                        fireErrors(docFile, new LineText[]{error} );
-                        packageHtmlErrors++;
-                    }
-                    fireFileFinished(docFile);
-                    checkedPackages.add(packageDir);
+                    final LineText error =
+                        new LineText(0, "missing package documentation file.");
+                    fireErrors(docFile, new LineText[]{error} );
+                    packageHtmlErrors++;
                 }
+                fireFileFinished(docFile);
+                checkedPackages.add(packageDir);
             }
         }
         return packageHtmlErrors;