From eae75a529f1c6c10f10e0806fd2a274bb630c9e3 Mon Sep 17 00:00:00 2001 From: Andrei Selkin Date: Sun, 6 Dec 2015 21:46:49 +0300 Subject: [PATCH] Issue #2604: Refactoring of SingleLineJavadoc to resolve LocalVariableName violation --- .../checks/javadoc/SingleLineJavadocCheck.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SingleLineJavadocCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SingleLineJavadocCheck.java index 0a1ba1804..f2b8d4045 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SingleLineJavadocCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SingleLineJavadocCheck.java @@ -22,6 +22,8 @@ package com.puppycrawl.tools.checkstyle.checks.javadoc; import java.util.ArrayList; import java.util.List; +import com.google.common.base.Splitter; +import com.google.common.collect.Lists; import com.puppycrawl.tools.checkstyle.api.DetailAST; import com.puppycrawl.tools.checkstyle.api.DetailNode; import com.puppycrawl.tools.checkstyle.api.JavadocTokenTypes; @@ -79,12 +81,8 @@ public class SingleLineJavadocCheck extends AbstractJavadocCheck { * @param tags to be ignored by check. */ public void setIgnoredTags(String tags) { - final List tagList = new ArrayList<>(); - final String[] sTags = tags.split(","); - for (String sTag : sTags) { - tagList.add(sTag.trim()); - } - ignoredTags = tagList; + ignoredTags = + Lists.newArrayList(Splitter.on(",").omitEmptyStrings().trimResults().split(tags)); } /**